I'd love it if by the end of WF 40 development in April we could get
the PR count in
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_wildfly_wildfly_pulls&d=DwIGaQ&c=BSDicqBQBDjDI9RkVyTcHQ&r=jkzpqYecGYBwrtYic9rrbWZKUtnC7idQHiEUxCw-JQk&m=afISijJ9dKakKy7xjCgilKZh6zBL9TukmldmB_jRD1SRz8q7yC4kuGiX1Wvo3Itm&s=MBGdHVTgCqowG3jL3eerGn8Mxv272On0pZkqiXKjnkA&e=
down to 50
and then keep it there going forward.
We spent much of the last year or two at around 100, which is not good
for contributors or for maintainers.
50 is an arbitrary number, but it seems reasonable. For example, it
would allow us to have in the queue:
10 Feature PRs
5 Dependabot PRs
10 misc non-Feature PRs that are quickly moving through a
review[/update/review]/merge cycle.
10 more difficult non-Feature PRs that are taking more than a couple
weeks to get in shape for merging
10 short term drafts where people using the PR queue to gather feedback on WIP
Plus a 5 PR buffer for when there are randomly more of some of those types.
The mix could of course be different over time.
Things to do to get there:
1) My favorite -- get our Features completed. We currently have 24 PRs
labeled as Feature. That is far too many.
2) My second favorite -- help review and merge PRs, particularly
non-Feature PRs, and including old ones.
3) Go on an exercise to get various PRs that fell into cracks merged
or closed. I made an effort on that in Nov/Dec which is one reason the
queue is now 73.
4) PRs that are not mergeable because they are missing some
requirement (say a WF Core upgrade) must be in 'Draft' state until
whatever they are waiting on is in process to become available (e.g.
the required change in Core is merged so we know it will be available
within a couple weeks.). Those drafts should become mergeable or be
closed within two or three weeks.
5) Resist the urge to use the PR queue to gather feedback on WIP. Are
you really looking for input from random people, or do you have
particular people in mind? If the latter, ask those people to look at
your branch in your personal repo. I'm not saying never open draft PRs
like this but don't leave them open for long periods, and definitely
not if work has halted for some reason.
6) Be willing to say no and close a PR if you are the component lead
for the relevant area.
WDYT?
Best regards,
Brian
_______________________________________________
wildfly-dev mailing list -- wildfly-dev@lists.jboss.org
To unsubscribe send an email to wildfly-dev-leave@lists.jboss.org
Privacy Statement:
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.redhat.com_en_about_privacy-2Dpolicy&d=DwIGaQ&c=BSDicqBQBDjDI9RkVyTcHQ&r=jkzpqYecGYBwrtYic9rrbWZKUtnC7idQHiEUxCw-JQk&m=afISijJ9dKakKy7xjCgilKZh6zBL9TukmldmB_jRD1SRz8q7yC4kuGiX1Wvo3Itm&s=h0dV6Ka4Dz56VPWzfs7sUDFdIh9TdBvxydVyyGeXMrs&e=
List Archives:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_archives_list_wildfly-2Ddev-40lists.jboss.org_message_5LBHWKLSOQERV4YI5GJ4WUYHFEWZMNVQ_&d=DwIGaQ&c=BSDicqBQBDjDI9RkVyTcHQ&r=jkzpqYecGYBwrtYic9rrbWZKUtnC7idQHiEUxCw-JQk&m=afISijJ9dKakKy7xjCgilKZh6zBL9TukmldmB_jRD1SRz8q7yC4kuGiX1Wvo3Itm&s=lpMHTkT0UU9liN6t5NVZkNoKTU8g4zTAD5jso6PxmDg&e=