Re: [windup-dev] Phases, after, before
On 29.1.2015 16:08, Ondrej Zizka wrote:
Notes:
1) Phase classes could perhaps end with ...Phase
2) Phases should be printed, sorted, before all rules are printed,
because if a cycle or rule deps error is detected, this message is not
printed and user doesn't have a hit on what's the right phase to put the
rule to.
3) I've updated
https://github.com/windup/windup/wiki/Rules-Rule-Execution-Lifecycle
with the list of phases, as a temporary info.
4) The Implicit phase should be
returned by getPhase() for rules whose
both after/before return something. See below.
I suggest that we do NOT set the default phase MigrationRules in case
both getExecuteAfter() and getExecuteBefore() are overriden (return
something).
That will allow users to omit getPhase().
See the code and exception below for motivation.
WDYT?