For the most part, we should be using absolute (canonicalized) paths
internally, as otherwise path comparisons can become difficult. You are
definitely right that we need to track things like archive
relationships, though (we already do this), as we need to be able to
figure out the relative paths later on.
Fortunately, we already do that. :)
On 08/12/2014 01:11 AM, Ondrej Zizka wrote:
Yes, in the end, it's for presentation.
But that means we need to use them internally too, otherwise they would
get lost on the way.
For example:
We have archive foo.war.
Extract it to $CWD/tmp/appsExtracted/foo.war/ (made up)
It has a lib.jar, to be extracted to
$CWD/tmp/appsExtracted/foo.war-lib.jar (made up).
To keep the relative information, we need to carry the relative paths,
and the context of what belongs under what.
Otherwise we would have to re-compute the paths during reporting phase,
which would be even harder to do right, IMO.
Ondra
On 11.8.2014 16:38, Jess Sightler wrote:
> For presentation to the user, I agree. I assume that is what you are
> talking about here?
>
> On 08/10/2014 11:00 PM, Ondrej Zizka wrote:
>> Hi,
>>
>> I suggest we use relative paths.
>> For the reports, using full paths may get overly verbose and make the
>> reports unreadable.
>> Relative paths are usually not, that much.
>> Compare e.g.:
>>
>> INFO: Unzipping
>>
/home/ondra/work/Migration/Windup/tests/core/target/../../../test-files/Windup1x-javaee-example.war
>> to
>>
/home/ondra/work/Migration/Windup/tests/core/target/windupreport/archives/Windup1x-javaee-example.war
>>
>> vs.
>>
>> INFO: Unzipping ../../../test-files/Windup1x-javaee-example.war to
>> windupreport/archives/Windup1x-javaee-example.war
>>
>> The base path may be stated just once somewhere else.
>>
>> From my experience, using relative paths may get tricky, needing to
>> carry the base path(s) along with the relative, but still, is worth the
>> work.
>>
>> my2c,
>> Ondra
>>
>> _______________________________________________
>> windup-dev mailing list
>> windup-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/windup-dev
> _______________________________________________
> windup-dev mailing list
> windup-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/windup-dev
_______________________________________________
windup-dev mailing list
windup-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/windup-dev