Problems with XML
by Lincoln Baxter, III
Matej,
This XML is repeated in almost all the rules we have so far...
> <perform>
> <iteration>
> <hint .... >
> </iteration>
> </perform>
This XML mayactually be creating a nested iteration over no elements. One
iteration created by default in the <perform> method, the next one by the
subsequent <iteration>...
Iteration is implied if omitted, so this may be the problem, not sure.
I am going to look into this more tomorrow. But if you get to it before I
do, this may be a place to start looking. Try removing the <iteration> tags
and putting the child nodes into <perform> directly.
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
9 years, 5 months
Windup Meeting Minutes - 2014-12-10
by Lincoln Baxter, III
Minutes:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Minutes (text):
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Log:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Meeting summary
---------------
* Agenda (lincolnthree, 15:02:08)
* Status Reports (lincolnthree, 15:02:14)
* Agenda (lincolnthree, 15:02:21)
* Status Reports (lincolnthree, 15:04:24)
* Nothing spectacular from me. I am working on merging the rule
parameterization and XML rule conversion, but running into a few
roadblocks (something not right with XML rules at the moment,) but
working on figuring it out. Seems like something simple.
(lincolnthree, 15:06:19)
* Once that is done (WINDUP-377) I plan on working on refactoring and
simplifying / reviewing UX. (lincolnthree, 15:06:43)
* I have resolved WINDUP-340 (report of freemarker functions and
directives) (jsightler, 15:09:21)
* WINDUP-382 - Increase defaults for permgen and codecachesize
(improves performance and avoids some common out of memory errors
with the defaults) (jsightler, 15:09:46)
* WINDUP-406 - TypeInterestFactory perf improvement
(typeinterestfactory is no longer our slowest point :) )
(jsightler, 15:10:11)
* And WINDUP-416 (memory usage reduction) (jsightler, 15:10:40)
* I'm planning to look over the current parameterization stuff soon,
and then hopefully continue with some performance stuff (maybe
multithreading in a couple of key places) (jsightler, 15:12:00)
* still playing with migrating legacy rules to XML, besides started to
work on WINDUP-407 ... (mbriskar, 15:12:38)
* Worked on the PRs as per comments: (ozizka, 15:20:20)
* Review rules metadata WINDUP-395 (ozizka, 15:20:21)
* WINDUP-394 Support default value in WindupConfigurationOption
(ozizka, 15:20:21)
* WINDUP-411 Report multiple rules sorting metadata errors at once
(ozizka, 15:20:21)
* WINDUP-417 WindupRuleProviderSorter - make the error message
clearer, shorten (ozizka, 15:20:21)
* Been working on a Ruleset for automated archives ignoring, the part
of getting data from JBoss Nexus (ozizka, 15:20:21)
* New Javadoc 2.0.0.Beta6 online (ozizka, 15:20:21)
* WINDUP-422 Make Javadoc crosslink with Forge (ozizka, 15:20:22)
* WINDUP-409 Allow rules metadata to annotations - @Rules (test not
finished, was not a priority) (ozizka, 15:20:22)
* Priorities (lincolnthree, 15:24:59)
* Priorities are unchanged: (lincolnthree, 15:28:54)
* 1. Rules parameterization & Usability improvements (lincolnthree,
15:29:10)
* 2. Performance enhancements (lincolnthree, 15:29:20)
* 3. Stability improvements (lincolnthree, 15:30:44)
* Rule Parameterization (lincolnthree, 15:31:26)
* LINK:
https://github.com/lincolnthree/windup/blob/PARAMETERIZED_RULES/rules-jav...
(jsightler, 16:11:41)
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
9 years, 5 months
XML rules test failure
by Ondrej Zizka
Hi,
this is what I get with current master.
However on Jenkins it's ok.
Any idea what can be wrong?
Thanks,
Ondra
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 18.532
sec <<< FAILURE! - in
org.jboss.windup.rules.xml.XMLTransformationXMLRulesTest
testXSLTTransformation(org.jboss.windup.rules.xml.XMLTransformationXMLRulesTest)
Time elapsed: 6.247 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at
org.jboss.windup.rules.xml.XMLTransformationXMLRulesTest.testXSLTTransformation(XMLTransformationXMLRulesTest.java:118)
Results :
Failed tests:
XMLTransformationTest.testXSLTTransformation:126 null
GroovyExtensionXmlRulesTest.testHintsAndClassificationOperation:120
expected:<2> but was:<0>
XMLFileNestedConditionTest.testNestedCondition:128 expected:<1> but
was:<0>
XMLHintsClassificationsTest.testHintAndClassificationOperation:130
expected:<2> but was:<0>
XMLTransformationXMLRulesTest.testXSLTTransformation:118 null
9 years, 5 months
Meeting topic: Parametrization
by Ondrej Zizka
Hi all,
I don't get the parametrization. Could we please include that on
tomorrow's meeting and discuss it a bit deeper than a link to
uncommented PR or code snippet? It may feel geeky to avoid creating a
normal text containing what should be achieved and what are the
available alternatives, but forgive me, I prefer to have it, at least
for such key concepts.
Thanks for understanding :)
Ondra
9 years, 5 months
Missing items from reports
by Lincoln Baxter, III
Hey Marc,
You'd mentioned that there was some missing information on the reports from Windup 2, could you give some examples of that? We'd like to get that fixed if possible!
Thanks,
Lincoln
--
Lincoln Baxter, III
JBoss, by Red Hat
lbaxter(a)redhat.com
"If you want something, you'll find a way; if you don't, you'll find an excuse."
9 years, 5 months
Windup meeting minutes - 2014-12-03
by Lincoln Baxter, III
Minutes:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Minutes (text):
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Log:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Meeting summary
---------------
* Agenda (lincolnthree, 15:04:09)
* Status Reports (lincolnthree, 15:08:29)
* last week I was on PTO. (I am off again on Friday) (lincolnthree,
15:09:08)
* This week I've reviewed some PRs and resumed work on the pr for
WINDUP-377 (lincolnthree, 15:09:23)
* I should have an integrated PR by this afternoon. I'm pretty close.
(lincolnthree, 15:09:40)
* I plan on finishing that up and doing general housekeeping for the
rest of the week. (lincolnthree, 15:11:12)
* I have fixed WINDUP-321 (internal tool for iterating over frames as
if they were just vertices), WINDUP-371 (crasher bug with some input
ears), and WINDUP-391 (Iteration support for the XML rules format)
(jsightler, 15:15:43)
* Also, the decompilation threading thing is finished (thanks mbriskar
for getting that going), and there is work in progress to really
speed up TypeInterestFactory (jsightler, 15:16:26)
* I am still migrating the rules from java to xml. I gathered the
functionality requests and put it inside the WINDUP-401 that is
already merged (mbriskar, 15:21:52)
* so now I continue and fixing some small issues, the xmls look almost
done, I am just perfectionalist because don't want to miss something
there (otherwise it would be just lost probably) (mbriskar,
15:22:35)
* plus trying to record the screencast for forge (but this does
nothing with windup) (mbriskar, 15:23:37)
* WINDUP-355 Victi.ms - finished, including report. (ozizka,
15:35:21)
* WINDUP-400 Renaming some methods - suggestion. (ozizka, 15:35:21)
* Looked shortly into XML tests crashing locally, didn't figure out
(ozizka, 15:35:21)
* Did WINDUP-395 Review rules metadata - IDs, categories etc.
(ozizka, 15:36:35)
* Did WINDUP-394 Support default value in
WindupConfigurationOption (ozizka, 15:37:05)
* Spent some time on wiki docs again, trying to systemize the Rulesets
subset (ozizka, 15:38:41)
* I Will need help from the team. I'm suggesting some structure, and
until automated (when Windup core is ready to give that), some
basic data will need to be added manually (ozizka, 15:39:44)
* Did WINDUP-411 Report multiple rules sorting
metadata errors at once (ozizka, 15:40:28)
* Did WINDUP-410 Weird wording of after/before vs.
phase constraints exceptions - not sure if PR was sent, if not, I
will (ozizka, 15:41:35)
* Fixed WINDUP-404 Returning this from Model setter
doesn't always work (at least for my case it works ;-) (ozizka,
15:42:37)
* I'd like to work on WINDUP-398 Rules request: Ignored jars by G:A:V
and hashes - another possible speedup. JBoss.org team works on a
tool from which we could get data automatically regularly. (ozizka,
15:48:13)
* IDEA: WINDUP-398 Rules request: Ignored jars by G:A:V and hashes
(ozizka, 15:48:14)
* IDEA: WINDUP-396 Automate copying options to graph (ozizka,
15:48:14)
* IDEA: WINDUP-387 Add to UI: "run this rule and all that it depends
on" (ozizka, 15:48:14)
* IDEA: WINDUP-384 Iteration.over(Foo.class) to load Foo's if none
found on varstack. (ozizka, 15:48:14)
* IDEA: WINDUP-409 Allow rules metadata to annotations - @Rules( phase
= ..., ...) (ozizka, 15:48:14)
* IDEA: WINDUP-403 Add "supported version range" to ruleset metadata
(ozizka, 15:48:14)
* IDEA: WINDUP-402 Change ruleset category metadata to tag-like system
(make it a set of strings) (ozizka, 15:48:14)
* IDEA: WINDUP-400 Rename some model methods (ozizka, 15:48:15)
* IDEA: WINDUP-397 Split XmlFileCondition from XmlFile (ozizka,
15:48:15)
* Project Priorities (lincolnthree, 15:52:23)
* Priorities remain unchanged. Performance and stability improvement
is #1 (lincolnthree, 15:52:39)
* Usability improvements #2 (including rules syntax/functionality)
(lincolnthree, 15:52:59)
* General enhancements and quality improvement / simplifications /
refactoring #3 (I think) (lincolnthree, 15:53:27)
* Hint.in vs Classification.of (lincolnthree, 15:54:19)
* Iteration.over() behaviour (lincolnthree, 15:58:40)
* WINDUP-399 Conditions and Operations in XML syntax
derived from class (without a need for wrapper) (ozizka, 16:07:19)
* Java vs xml rules (ozizka, 16:07:58)
* About XML vs. Java - I often see some statements like "users prefer
that" or "that will better be done with XML syntax", but I do not
know about any bigger to-the-point document or discussion of these
statements. I don't know what the XML syntax will cover, whether it
will have a generic nature or rather specialized, backed by a
Ruleset / Conditions / Operations (ozizka, 16:08:02)
Meeting ended at 16:28:11 UTC.
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
9 years, 5 months
Reliably getting class name of a RuleProvider?
by Ondrej Zizka
Hi,
I want to filter the rule providers.
Due to modularization, the Class object may not equal().
Due to Javassist, the class name is org.foo.Bar_$$_javassist_....
How can I reliably identify the class of the Rule provider?
Thanks,
Ondra
9 years, 5 months
XmlFile vs. XmlFileCondition
by Ondrej Zizka
Hi,
wouldn't it be better to split XmlFile's static code from what should
really be a XmlCondition? For the sake of code readability and
debugging. From user's PoV it would be the same - he would still see
.when(XmlFile.matchesXpath("//catalog/chain | //catalog/chains"))
Regards,
Ondra
9 years, 5 months
