Github PR rebase script // Fwd: Re: Git pull request automation?
by Ondrej Zizka
Here is a script which Brian uses to rebase and merge selected PR's.
Could be handy.
HTH,
Ondra
-------- Original Message --------
Subject: Re: Git pull request automation?
Date: Tue, 30 Apr 2013 09:47:20 -0500
From: Brian Stansberry <brian.stansberry(a)redhat.com>
To: Ondrej Zizka <ozizka(a)redhat.com>
CC: Carlo de Wolf <cdewolf(a)redhat.com>
AIUI Carlo's team is building some automation around this for EAP.
I have a simple script I use to bring down a bunch of pull requests into
a single branch.[1] I then push that branch to upstream master-ignore.
Lightning and Tomaz Cerar's team city test that branch whenever changes
are made. If that goes well, I merge the branch to master and push.
The other mergers do similar things, probably with better scripts for
the first bit.
I don't use the requester's remote; the PR is available via the wildfly
github repo. See the script for details.
[1]
pull() {
cmd="git fetch upstream master "
for var in "$@"
do
cmd="$cmd pull/$var/head:pullRequest$var"
done
$cmd
git branch -D pulls
git checkout master
git rebase upstream/master
git checkout -b pulls
for var in "$@"
do
git checkout pullRequest$var
git rebase pulls
git checkout pulls
git merge pullRequest$var
git branch -D pullRequest$var
done
}
On 4/30/13 9:16 AM, Ondrej Zizka wrote:
> Hi Brian,
>
> if I want to test and review the pull request before merging, it seems
> that I have to add the requester's remote, fetch it, check out his
> branch, then do what I want.
>
> With the pace of PRs to AS, I assume you have some automation for this,
> perhaps through GitHub API. Is that available somewhere?
> Or how do you proceed when you need to check something in an IDE, or
> test something not covered by the testsuite, etc?
>
> Thanks,
> Ondra
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
11 years, 10 months
Negative queries?
by Ondrej Zizka
When talking to Robb, we discussed the ability to query for POJO classes
- i.e. those which do not have any vendor-specific extension, do not use
blacklisted classes, do not extend something "dirty", etc.
Which brings us to interesting concept - querying for something "not
being a lot of things".
We have discussed this briefly on F2F with Brad.
The first shot could be:
* creating a method which will query for vertexes that have some frame
type (JavaClass), but not any other, or a set of other types
(WebLogicContextListener).
* querying for vertices which are not linked to vertices in sevral
blacklists
For example, querying for JavaClass'es not linked to a list of
other JavaClass'es by an "extends" edge.
This will need some way to keep the blacklists in the graph, and
then, I can imagine Gremlin taking the part in filtering out the
vertices linked to them by a set of edge types ("extends", "implements",
"annotatedBy", "calls", "imports", ...)
And creating a disjunction of all these results, by narrowing the set of
candidate vertices, step by step.
What I think is a BAD approach, is this kind of rules (outside of Java
basic analysis):
Query.find(JavaClassModel.class).as("javaClasses")
Iteration.over("javaClasses").as("javaClass").perform(
...
)
my2c,
Ondra
11 years, 10 months
100 MB demo app
by Ondrej Zizka
Found an interesting relatively large app:
http://sourceforge.net/projects/jbilling/files/latest/download
App: 20 MB
Libs: 80 MB
Includes: Java EE, Spring, JSP, web services, Struts, Grails, Drools,
SiteMesh, Hubernate.
Also what makes it interesting that it contains quite a lot of classes
generated by Grails.
Could be a nice minefield for java stuff - decompiler, BCEL.
Wanna give it a try? :)
Ondra
11 years, 10 months
Forge 2.7.3?
by Ondrej Zizka
Hi, I am hitting FORGE-1199, can we use Forge 2.7.3-SNAPSHOT until it is
released?
Thanks,
Ondra
11 years, 10 months
LinkageError: previously loaded "FramedGraph"
by Ondrej Zizka
Hi,
I am getting this in a test:
java.lang.LinkageError: loader constraint violation: loader (instance of
org/jboss/modules/ModuleClassLoader) previously initiated loading for a
different type with name "com/tinkerpop/frames/FramedGraph"
Any idea why? This should be prevented by modular classloading... anyone
willing to try?
Thanks,
Ondra
11 years, 10 months
Windup Meeting Minutes - 2014-08-05
by Lincoln Baxter, III
Minutes:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Minutes (text):
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Log:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2014/windup....
Meeting summary
---------------
* Agenda (lincolnthree1, 14:11:27)
* Status Updates (lincolnthree1, 14:15:14)
* Last week I was on vacation and completely ignored anything from
work, so now I have a pile of stuff to get through and issues to
resolve. (lincolnthree1, 14:15:41)
* I'm going to be working on ozizka's classloading issues and also the
WINDUP- 133 refactoring (lincolnthree1, 14:16:08)
* Since WINDUP-133 not being resolved, I stopped the work on the
migration and started to work on adding some new tests and thinking
about how to simplify the rules (mbriskar, 14:17:14)
* According to the simplification, with Jess we came up with
WINDUP-156, which now has it's PR in the windup (mbriskar,
14:18:11)
* according to the tests, I was adding the tests to the upcoming
issues or places I thought some test could be present. So I added
test for the upcoming WINDUP-167 and also for the GraphService
(which didn't have some basic tests). (mbriskar, 14:19:57)
* I was on vacation and am starting back today. (jsightler, 14:22:22)
* I was working on reporting and get into few issues (ozizka,
14:25:09)
* Mostly with classloading. Going to fix with Lincoln's help (ozizka,
14:25:37)
* Besides that, I worked on the server-side rules, (ozizka, 14:26:09)
* and again, wiki (ozizka, 14:26:51)
* Classloader issues (summary and how to reproduce) (lincolnthree1,
14:29:40)
* LINK: https://issues.jboss.org/browse/WINDUP-178 (ozizka,
14:29:48)
* Steps to reproduce: (lincolnthree1, 14:33:04)
* 1. Checkout and build:
https://github.com/OndraZizka/windup/tree/ReportCommons (skip tests)
(lincolnthree1, 14:34:21)
* 2. Run tests in "windup-reporting-xslt" sub-module. (lincolnthree1,
14:34:39)
* Related issue: https://issues.jboss.org/browse/FORGE-1969
(lincolnthree1, 14:36:09)
* WINDUP-133 (lincolnthree1, 14:36:58)
* Logging (lincolnthree1, 14:55:31)
* WINDUP-168 (lincolnthree1, 15:01:19)
Meeting ended at 15:16:30 UTC.
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
11 years, 10 months
Half day PTO
by Ondrej Zizka
Sorry, sent from wrong account... correction.
Hi,
I need to take a half-day PTO. I'll be back for the meeting.
Regards,
Ondra
11 years, 10 months
Half day PTO
by "Ing. Ondřej Žižka"
Hi,
I need to take a half-day PTO. I'll be back for the meeting.
Regards,
Ondra
11 years, 10 months
.when( new True() )
by Ondrej Zizka
Hi,
I found this rule being invoked many many times.
Since there's just .when( new True() ) and not some iteration, I wonder
what are the elements that it executes over so many times.
And how do I get this information from the current API?
Thanks,
Ondra
ruleSet("ExampleGroovyRule").setPhase(RulePhase.MIGRATION_RULES)
.addRule()
.when(
new True()
)
.perform(
new GraphOperation () {
public void perform(GraphRewrite event, EvaluationContext
context) {
//System.out.println("Performing rewrite operation")
Logging.of(this.getClass()).info("Performing rewrite
operation in ExampleGroovyRule");
}
}
11 years, 10 months
