Phases, after, before
by "Ing. Ondřej Žižka"
Hi all,
see the code below.
Originally I thought that getPhase() was removed entirely.
Now I see that we have all of getExecuteAfter(), getExecuteBefore() and
getPhase().
I suggest that we do NOT set the default phase MigrationRules in case
both getExecuteAfter() and getExecuteBefore() are overriden (return
something).
That will allow users to omit getPhase().
See the code and exception below for motivation.
WDYT?
===============================
public class SkipArchivesRules extends WindupRuleProvider
{
@Override
public List<Class<? extends WindupRuleProvider>> getExecuteAfter()
{
return asClassList(IdentifyArchivesRules.class,
SkipArchivesLoadConfigRules.class);
}
@Override
public List<Class<? extends WindupRuleProvider>> getExecuteBefore()
{
return asClassList(DecompileArchivesRuleProvider.class);
}
java.lang.RuntimeException: Dependency cycles detected: Found dependency
cycle involving: _DEFAULT_.SkipArchivesRules
Subcycle: _DEFAULT_.SkipArchivesRules
Subcycle:
org.jboss.windup.rules.apps:rules-java.DecompileArchivesRuleProvider
Subcycle:
org.jboss.windup.quickstarts:windup-skiparchives.IdentifyArchivesRules
Subcycle: InitialAnalysis
Subcycle:
org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesLoadConfigRules
Subcycle:
org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesRules
Subcycle: MigrationRules
Subcycle:
org.jboss.windup.rules.apps:rules-java.AnalyzeJavaFilesRuleProvider
10 years, 11 months
IdentifyArchives / SkipArchives - state
by Ondrej Zizka
Hi,
sorry to say I'm a bit late with this due to the Forge issue.
Since I'll be on training tomorrow and this could block release (?),
here's the status:
What's freshly done:
The data bundle - something that creates a fresh .zip artifact with
the SHA1 -> GAV mapping from Maven Central during the build.
What's missing:
Loading this bundle into the class which does actual identification.
Not tested in rules - only pieces.
Both should be relatively easy to fix:
Loading is probably matter of adding the right addon to classpath
and feeding the resource to ArchiveGAVIdentifier.addMappingsFrom(is); in
IdentifyArchivesLoadConfigRules.
Tests are roughly written IIRC, only I got stuck with the mentioned
issue and then was debugging them.
Need to go sleep, the training starts in 4,5 hours.
Ondra
10 years, 11 months
Common parent for windup core and windup BOM?
by Ondrej Zizka
Hi,
to keep the Forge versions aligned, and generally let those two share
some properties, plugin configs, versions etc.,
we could let them have a common parent. To prevent issues like we were
solving now - with <version.forge> differing in those two, causing
https://issues.jboss.org/browse/FORGE-2206 .
Note that it would not mean moving everything under a new directory
level - parent can be in a sibling directory.
WDYT?
Ondra
10 years, 11 months
Discussion: Data files in maven repo
by Ondrej Zizka
Hi,
WRT WINDUP-459 <https://issues.jboss.org/browse/WINDUP-459> Rules
request: Identify archives by their hash:
I guess this need (for bulk data from an external source) will appear in
more rulesets.
We agreed that the best way to build, store and distribute the offline
data will be best through artifacts, resp. through a maven repo.
1) Should it have independent release cycle? IMO it should.
2) If so - which git repo to put it to?
3) Can Forge/Furnace work well with ZIP artifacts? I.e, if there's a
<packaging>zip</packaging>, can that be an addon?
4) If something is an addon, is it better to access it as a resource on
classpath, or as a zip file, after figuring out where it is on local FS?
FYI, currently I just create a zip assembly
windup-nexusindexreader-mappings-<V>.jar, next to
windup-nexusindexreader-<V>.jar
The artifact size is 45 MB.
Regards,
Ondra
10 years, 11 months
Status
by Ondrej Zizka
I'm on a training today so here's my status if I don't make it to the
meeting:
#info I was working on the SkipArchives / IdentifyArchives ruleset,
according to the plan in last status / meeting.
#info Namely, I was working on the tests, on the data retrieval, on data
bundle. Delayed a bit by BOM Forge version not updated along with Windup
core.
#info See the mail "[windup-dev] IdentifyArchives / SkipArchives -
state" for details.
#info Plan: Finish that ASAP.
Regards,
Ondra
10 years, 11 months
Shortening of iteration
by Ondrej Zizka
Hi all,
could this
.addRule()
.when(Query.fromType(ArchiveModel.class))
.perform(Iteration.over(ArchiveModel.class)
.perform(new AbstractIterationOperation<ArchiveModel>()
{
@Override
public void perform(GraphRewrite event,
EvaluationContext evCtx, ArchiveModel arch)
{
be just
.addRule()
.perform(new IterationOver(ArchiveModel.class) {
@Override
public void perform(GraphRewrite event,
EvaluationContext evCtx, ArchiveModel arch)
{
?
If it can ( a. principially, b. nobody objects), I could try coding it.
Thanks,
Ondra
10 years, 11 months
Windup Meeting Minutes - 2015-01-28
by Lincoln Baxter, III
(If you are only looking for the release status update, here it is.)
* GA Release Status (lincolnthree, 16:01:07)
* Assuming we can get the skipjars functionality merged in today, we
are on schedule for releasing GA on FRIDAY (lincolnthree, 16:06:04)
Minutes:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup....
Minutes (text):
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup....
Log:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup....
Meeting summary
---------------
* Agenda (lincolnthree, 15:15:03)
* Status Reports (lincolnthree, 15:15:37)
* was working with Roman (our consultant) to create some new rules
(all counter are about 14). One I was not able to deliver and one
only partly, because we don't have functionality yet (mbriskar,
15:17:06)
* cleaned and pushed WINDUP-435: Rexster tests (mbriskar, 15:17:32)
* cleaned and pushed WINDUP-424 (mbriskar, 15:17:50)
* Last week I worked on setting up more relationships with teams
starting to use Windup, so hopefully we'll get some more feedback
soon. (lincolnthree, 15:23:38)
* I also worked on reviewing quite a few PRs, implemented WINDUP-484,
and WINDUP-312 (lincolnthree, 15:25:34)
* I'm working on our product integration plan, such as how other teams
will be required to contribute rules for new product releases
(lincolnthree, 15:26:13)
* I'm also working on the GA release tasks, code cleanup, and making
sure that our release is actually including the right stuff, and
that what we include/exclude is properly "messaged" to people who
are waiting on the release :) (lincolnthree, 15:26:58)
* I have worked on WINDUP-164 (Query.fromType(...).excludingType(...))
(jsightler, 15:28:25)
* Also, WINDUP-267 (Adding EJB lists, spring bean lists, and hibernate
information to the reports) (jsightler, 15:28:50)
* WINDUP-367 - FileContent searches (and support for this in our XML
rules) (jsightler, 15:29:07)
* Also, various bugfixes and working through some PRs and the
transition to the new extensible RulePhase system (WINDUP-277)
(jsightler, 15:29:55)
* I am currently working on RulePhase documentation, and then I'll be
working on testing (and any remaining issues) for the release
(jsightler, 15:30:56)
* (ozizka) I was working on the SkipArchives / IdentifyArchives
ruleset, (jsightler, 15:37:50)
* (ozizka) Namely, I was working on the tests, on the data retrieval,
on data (jsightler, 15:37:50)
* (ozizka) See the mail "[windup-dev] IdentifyArchives / SkipArchives
- (jsightler, 15:37:51)
* (ozizka) Plan: Finish that ASAP. (jsightler, 15:37:57)
* (ozizka) I was working on the SkipArchives / IdentifyArchives
ruleset, according to the plan in last status / meeting.
(jsightler, 15:38:43)
* (ozizka) Namely, I was working on the tests, on the data retrieval,
on data bundle. Delayed a bit by BOM Forge version not updated along
with Windup core. (jsightler, 15:38:43)
* (ozizka) See the mail "[windup-dev] IdentifyArchives / SkipArchives
- state" for details. (jsightler, 15:38:43)
* (ozizka) Plan: Finish that ASAP. (jsightler, 15:38:43)
* I have created 18 migration KBase articles here:
https://access.redhat.com/search/browse/articles#?&col=portal_articles&la...
(sgilda, 15:43:31)
* I've updated the spreadsheet with the Kbase article links:
https://docs.google.com/spreadsheets/d/19xaibv1xZr1L3ss256A9ak08oqg-zFxuv...
(sgilda, 15:45:02)
* Priorities (lincolnthree, 15:52:10)
* Getting the GA release out (lincolnthree, 15:52:20)
* Continuing to support windup users / etc (lincolnthree, 15:52:40)
* GA Release Status (lincolnthree, 16:01:07)
* Assuming we can get the skipjars functionality merged in today, we
are on schedule for releasing GA on FRIDAY (lincolnthree, 16:06:04)
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
10 years, 11 months
Build failure question (answer)
by Lincoln Baxter, III
As far as I know, this is a dependency failure exception because a
dependency could not be found, but it doesn't specifically say it
failed in a given repository, so I'm guessing this is not the same
issue. Possible that snapshots were deploying while the build was
running.
> hey Lincoln, can you just briefly check the output here https://10.3.9.192/job/windup-illegalstate-fix/5/console ? Is that the problem with nexus we have now?
[ERROR] Failed to execute goal
org.jboss.forge.furnace:furnace-maven-plugin:2.13.2-SNAPSHOT:generate-dot
(generate-dot) on project facets: Execution generate-dot of goal
org.jboss.forge.furnace:furnace-maven-plugin:2.13.2-SNAPSHOT:generate-dot
failed: Plugin org.jboss.forge.furnace:furnace-maven-plugin:2.13.2-SNAPSHOT
or one of its dependencies could not be resolved: The following
artifacts could not be resolved:
org.jboss.forge.furnace:furnace-api:jar:2.13.2-SNAPSHOT,
org.jboss.forge.furnace:furnace-manager-spi:jar:2.13.2-SNAPSHOT: Could
not find artifact
org.jboss.forge.furnace:furnace-api:jar:2.13.2-SNAPSHOT -> [Help 1]
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
10 years, 11 months
Windup Meeting Minutes - 2015-01-21
by Lincoln Baxter, III
Minutes:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup....
Minutes (text):
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup....
Log:
http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup....
Meeting summary
---------------
* Agenda (lincolnthree, 15:04:02)
* Status Reports (lincolnthree, 15:06:10)
* Last week I worked mostly on preparing and giving two SA outreach
presentations on Thursday and Friday (lincolnthree, 15:07:14)
* This week I've been working on PR review, some design review, and
setting up some more relationships with consulting teams.
(lincolnthree, 15:07:36)
* Today and for the rest of this week, my plan is to fix the relative
paths bug in our UI, start working on the rule organization issues,
and hopefully review the default ignore list. (lincolnthree,
15:08:23)
* I have finished WINDUP-462 (removing now redundant org.windup
@Property annotation) (jsightler, 15:09:36)
* I have also finished WINDUP-448 (XmlFile parameterization)
(jsightler, 15:09:50)
* I am presently working on WINDUP-367 (jsightler, 15:10:13)
* I will resume WINDUP-277 shortly (replacing the windup RulePhase
enumeration with marker implementations of WindupRuleProvider)
(jsightler, 15:10:46)
* I was working on IllegalStateException, I think we are together
reaching to some solution, however I can't continue now because of
other things comming up (mbriskar, 15:13:02)
* I worked on WINDUP-454, that means being able to ignore according to
the file path (mbriskar, 15:13:25)
* and worked on the rexster tests. I need to clean a little bit the
commit and then I can send PR (mbriskar, 15:18:01)
* I am mainly going to help people to use windup and write rules next
week (mbriskar, 15:18:39)
* I am continuing on SkipArchives ruleset: (ozizka, 15:21:10)
* - created the Nexus index extractor (ozizka, 15:21:10)
* - written the library to read the files and resolve G:A:V from SHA1
hash (ozizka, 15:21:10)
* - written the HTTP retriever which would need a servlet that would
find G:A:V by SHA1 hash (ozizka, 15:21:10)
* - Also added another way to retrieve the same data - Solr, not sure
which one is better. (ozizka, 15:21:10)
* - I'll also make this depending on the --offline param (ozizka,
15:21:11)
* - Writing the POM stuff that will pack the extracted mapping file
into an artifact (ozizka, 15:21:11)
* - Started writing the tests for SkipArchives (ozizka, 15:21:12)
* Priorities & Windup 2.0.0.Final Next Steps (lincolnthree, 15:32:16)
* we have a list of JIRA tasks that should get finished by .Final if
possible (lincolnthree, 15:32:39)
*
https://issues.jboss.org/issues/?jql=project%20%3D%20WINDUP%20AND%20resol...
(lincolnthree, 15:33:03)
* I'll be working on some of the UI issues, and also working on
restructuring the addons to fit the api/impl split layout
(lincolnthree, 15:35:04)
* Please focus on this list of tasks :) (lincolnthree, 15:35:20)
* LINK:
https://github.com/windup/windup/pull/411/files#diff-35f7c9dd98edecb1bcfd...
(lincolnthree, 15:40:19)
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
10 years, 11 months
