Re: [windup-dev] Deps in windup-rules-java-api

From: "Ondrej Zizka" <ozizka(a)redhat.com&gt; To: windup-dev(a)lists.jboss.org Sent: Tuesday, April 19, 2016 7:28:02 AM Subject: Re: [windup-dev] Deps in windup-rules-java-api There's a difference whether it's in the addon or in the submodule. Submodule can have a compile time dependency. Addon should have provided. The rules for addon pom.xml deps are quite complex, once I wrote down what I knew to those pages on wiki, but there are blank spots. +1 that we could review the deps. At least we would refresh how it should be. Ondra On 18.4.2016 14:54, Jess Sightler wrote: > Feel free to try it. "provided" is generally what we would do in those > cases. > > On 04/15/2016 07:02 PM, Ondrej Zizka wrote: >> Hi, >> >> I've noticed that in the pom.xml of $subj, there is: >> >> <dependency> >> <groupId>org.jboss.windup.ast</groupId> >> <artifactId>windup-java-ast</artifactId> >> <classifier>forge-addon</classifier> >> <scope>compile</scope> >> </dependency> >> <dependency> >> <groupId>org.jboss.windup.rules.apps</groupId> >> <artifactId>windup-rules-base</artifactId> >> <classifier>forge-addon</classifier> >> <scope>compile</scope> >> </dependency> >> >> >> Shouldn't that be of scope provided, and listed in ../addon/pom.xml ? >> >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev _______________________________________________ windup-dev mailing list windup-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev