8:31 p.m.
@Override
public String getId()
{
return this.getClass().getName() + "_" +
UUID.randomUUID().toString();
}
Isn't it a potential problem that this returns different values on each
call?
Shouldn't it store a value once called? Or derive the value from, say, a
class object? Or just use Class#hashCode()?
And maybe this method's default impl should move to GraphRule?
What if we refrained from using UUID which gives unnecessary long
strings, and used RandomStringUtils.randomAlphanumeric(6) or such?
And lastly, this could be
Regards,
Ondra
10:28 a.m.
On 03/24/2015 09:31 PM, Ondrej Zizka wrote:
@Override
public String getId()
{
return this.getClass().getName() + "_" +
UUID.randomUUID().toString();
}
Isn't it a potential problem that this returns different values on each
call?
Shouldn't it store a value once called? Or derive the value from, say, a
class object? Or just use Class#hashCode()?
I agree. It seems like a mistake that repeated calls to the same object
here will return different values.
6:11 p.m.
Yep, that seems like a problem.
On Wed, Mar 25, 2015 at 11:28 AM, Jess Sightler <jsightle(a)redhat.com> wrote:
On 03/24/2015 09:31 PM, Ondrej Zizka wrote:
> @Override
> public String getId()
> {
> return this.getClass().getName() + "_" +
> UUID.randomUUID().toString();
> }
>
> Isn't it a potential problem that this returns different values on each
> call?
> Shouldn't it store a value once called? Or derive the value from, say, a
> class object? Or just use Class#hashCode()?
I agree. It seems like a mistake that repeated calls to the same object
here will return different values.
_______________________________________________
windup-dev mailing list
windup-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/windup-dev
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
3851
days inactive
3853
days old
2 comments
3 participants
participants (3)
-
Jess Sightler -
Lincoln Baxter, III -
Ondrej Zizka