7:48 p.m.
ClassFilePreDecompilationScan:
try (InputStream is = fileModel.asInputStream())
{
addClassFileMetadata(event, context, fileModel);
This is opening the stream twice; shouldn't it be rather this?
addClassFileMetadata(event, context, fileModel);
try (InputStream is = fileModel.asInputStream())
{
Ondra
7:50 p.m.
New subject: BCEL, then ASM? /// Re: Opening two streams for .class
Also, there's BCEL, then ASM parsing of .class.
Are they complements? Can't one do it all?
Ondra
On 20.10.2015 02:48, Ondrej Zizka wrote:
ClassFilePreDecompilationScan:
try (InputStream is = fileModel.asInputStream())
{
addClassFileMetadata(event, context, fileModel);
This is opening the stream twice; shouldn't it be rather this?
addClassFileMetadata(event, context, fileModel);
try (InputStream is = fileModel.asInputStream())
{
Ondra
_______________________________________________
windup-dev mailing list
windup-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/windup-dev
11:52 a.m.
New subject: BCEL, then ASM? /// Re: Opening two streams for .class
Yes, I think that can (and should) be changed.
On 10/19/2015 08:50 PM, Ondrej Zizka wrote:
Also, there's BCEL, then ASM parsing of .class.
Are they complements? Can't one do it all?
Ondra
On 20.10.2015 02:48, Ondrej Zizka wrote:
> ClassFilePreDecompilationScan:
>
> try (InputStream is = fileModel.asInputStream())
> {
> addClassFileMetadata(event, context, fileModel);
>
> This is opening the stream twice; shouldn't it be rather this?
>
> addClassFileMetadata(event, context, fileModel);
> try (InputStream is = fileModel.asInputStream())
> {
>
> Ondra
> _______________________________________________
> windup-dev mailing list
> windup-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/windup-dev
_______________________________________________
windup-dev mailing list
windup-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/windup-dev
3373
days inactive
3373
days old
2 comments
2 participants
participants (2)
-
Jess Sightler -
Ondrej Zizka