Hi, there's a lot of XML config related code in the core. I suggest to put that to an extension, next to groovy. That's the exact place it should be. Ondra _______________________________________________ windup-dev mailing list windup-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev

Hi, The XmlConfigSplit-* branches push the core vs. rulesets split further. Currently it's XmlConfigSplit-3. Touches mainly config-xml and reporting. Could you please review and ack merging? Regards, Ondra On 19.6.2014 19:37, Lincoln Baxter, III wrote: > Yes. Agreed. This is the right thing to do. > > > On Thu, Jun 19, 2014 at 9:37 AM, Ondrej Zizka <ozizka(a)redhat.com > <mailto:ozizka@redhat.com>> wrote: > > Hi, > > there's a lot of XML config related code in the core. > I suggest to put that to an extension, next to groovy. That's the > exact > place it should be. > > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev(a)lists.jboss.org <mailto:windup-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev _______________________________________________ windup-dev mailing list windup-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev

I had made a few comments on github. Did you see them? On Mon, Jun 23, 2014 at 5:58 AM, Ondrej Zizka <ozizka(a)redhat.com <mailto:ozizka@redhat.com>> wrote: I've added few more and rebased, now it's Xml...-4. https://github.com/windup/windup/pull/104 Ondra On 23.6.2014 04:05, Ondrej Zizka wrote: > Hi, > > The XmlConfigSplit-* branches push the core vs. rulesets split > further. > Currently it's XmlConfigSplit-3. > Touches mainly config-xml and reporting. > Could you please review and ack merging? > > Regards, > Ondra > > > > On 19.6.2014 19:37, Lincoln Baxter, III wrote: >> Yes. Agreed. This is the right thing to do. >> >> >> On Thu, Jun 19, 2014 at 9:37 AM, Ondrej Zizka <ozizka(a)redhat.com >> <mailto:ozizka@redhat.com>> wrote: >> >> Hi, >> >> there's a lot of XML config related code in the core. >> I suggest to put that to an extension, next to groovy. >> That's the exact >> place it should be. >> >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev(a)lists.jboss.org <mailto:windup-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev(a)lists.jboss.org <mailto:windup-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev(a)lists.jboss.org <mailto:windup-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev _______________________________________________ windup-dev mailing list windup-dev(a)lists.jboss.org <mailto:windup-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/windup-dev -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." _______________________________________________ windup-dev mailing list windup-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev