[aerogear-dev] Last minute change in Push Server API required?

[Kris Borchers]

On Aug 15, 2013, at 9:01 AM, Matthias Wessendorf <matzew at apache.org> wrote:

> Kris - I guess this is the 'problem':
> 
> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/iOSVariantEndpoint.java#L193
> 
> I always did CURL DELETE, but I NEVER gave payload with it .... but....... (my bad?) I did always include this:
> 
> curl -v -b cookies.txt -c cookies.txt -v -H "Accept: application/json" -H "Content-type: application/json"  -X DELETE

Oh, yeah if you're referring to the Content-type that should not be required for DELETE
> .........
> 
> 
> On Thu, Aug 15, 2013 at 3:59 PM, Kris Borchers <kris at redhat.com> wrote:
> Yeah, I assumed this was an actual problem but don't see any reference to our spec or code where we require a body for DELETE. Karel, can you add that to the JIRA or at least clarify what actual issue you have run into?
> 
> On Aug 15, 2013, at 8:54 AM, Matthias Wessendorf <matzew at apache.org> wrote:
> 
>> Hello,
>> 
>> We have "@Delete APIs" that are used by the devices/client (for unregistrations), but that does not require any data:
>> ==> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/installations/InstallationRegistrationEndpoint.java#L117-L122
>> It only reads the /token from the URL and the headers (for basic)
>> 
>> We have other endpoints that are used by the AdminUI, e.g.
>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/iOSVariantEndpoint.java#L190-L203
>> That also really just reads out of the URL .
>> 
>> 
>> I also don't see where the spec, e.g.:
>> http://staging.aerogear.org/docs/specs/aerogear-push-rest/PushApplication/
>> talk about JSON payload required
>> 
>> 
>> 
>> -Matthias 
>> 
>> 
>> 
>> On Thu, Aug 15, 2013 at 3:35 PM, Karel Piwko <kpiwko at redhat.com> wrote:
>> Hi All,
>> 
>> I think that DELETE requests in Push Server do not conform to HTTP/REST
>> specifications because they require request body. More details here:
>> 
>> https://issues.jboss.org/browse/AGPUSH-298
>> 
>> Should we change them in 0.8.0 release?
>> 
>> Thanks,
>> 
>> Karel
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> 
>> 
>> 
>> -- 
>> Matthias Wessendorf 
>> 
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> 
> 
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> 
> 
> 
> -- 
> Matthias Wessendorf 
> 
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20130815/5e3aaaa5/attachment.html