[aerogear-dev] Bundling Dependencies

[Lucas Holmquist]

ok,  so here is the previous thread about this

http://bit.ly/V551nI


This is a bit tricky since the way someone can get the libs are different.

1. Bower
2. Custom Builder
3. github - clone src, build
4. ????


With bower,  socksjs is available, but not vertxbus.js or stomp.js,   we could create repo's to "host" those 2 so bower can find them.  It doesn't have to be an official aerogear repo,  it can be mine.  i've seen this done before.

i sort of like this since bower will then pull in everything.  i actually had to tell bower to get 1.0.1 for the push admin ui, since i didn't want to look for the other dependencies.

although,  i didn't need them,  i wonder if we should maybe have a "core" branch, where just the 1.0.X stuff lives.  although that could complicate things with bower possibly.


i believe with the github options, we have a list of dependencies on the read me with links on where to get them.

With the custom builder,  we could package the appropriate dependencies.  





On Jul 8, 2013, at 8:03 AM, Kris Borchers <kris at redhat.com> wrote:

> So I have a dilemma on which I would like input from the team. In https://issues.jboss.org/browse/AGJS-48 qmx reports that he gets:
> 
> Uncaught ReferenceError: vertx is not defined at aerogear.js:2627
> 
> when using AeroGear.js in a blank page. The reason for this is that the full build of AeroGear.js contains the new vert.x and STOMP over websocket adapters for Notifier. These adapters have dependencies on vertxbus.js and stomp.js respectively. Since they are not included in the page, you get that error. Here is the dilemma.
> 
> Do I bundle those files into AeroGear.js as part of the build when those adapters are included or not? The reason I did not is because they are external dependencies and I didn't want them bloating the file size just like we do with jQuery. That said, it's obviously easy to not realize you need those files, especially if you grab AeroGear.js and don't intend on using the Notifier bits or just grab it and throw it in a page and see those errors as qmx did.
> 
> Thoughts?
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20130708/31e8c1f3/attachment.html