[aerogear-dev] Aerogear-Controller-Demo Functional Test

[Apostolos Emmanouilidis]

Hi Karel,

Thank you for your comments.

I've removed the parent POM XML, synchronized the forked repository with
the original/parent Aerogear-Controller-Demo repository, performed the
required actions so that my master branch is ahead of the
original/parent Aerogear-Controller-Demo master branch by one commit
and finally created a pull request.

The changes included in the commit are:

        1. Created subfolder aerogear-controller-demo and moved the
        content of the initial project inside
        2. Created subfolder aerogear-controller-demo-ftest which
        contains the functional test
        3. Modified the gitignore file to ignore some files and folders
        inside the above created subfolders
        

Thank you,
Tolis

On Fri, 2013-03-22 at 15:15 +0100, Karel Piwko wrote:

> Tolis,
> 
> thank you for driving this!
> 
> Now a few comments: Having a parent pom is not necessary. As we agreed during
> JDF quickstarts discussions, the best way to handle example + test scenario
> that is to have no parent at all. 
> 
> Users will not get confused while importing into JBDS. Power users willing to
> see how to test that will simply import a second project. Test project itself is
> packaged in aerogear-controller-demo/functional-test so it won't disturb
> users with two directories per project.
> 
> Karel
> 
> On Thu, 21 Mar 2013 22:31:51 +0100
> Apostolos Emmanouilidis <aemmanou at redhat.com> wrote:
> 
> > Hi,
> > 
> > Just wanted to inform you that I've added a functional test for the
> > Aerogear-Controller-Demo in the GitHub repo [1]
> > 
> > I created a parent POM which contains 2 modules, the first module is the
> > aerogear-controller-demo and the second one is the
> > aerogear-controller-demo-ftest. The aerogear-controller-demo version is
> > the latest one until the moment I'm writing this e-mail. The only change
> > which has been done in the aerogear-controller-demo is that the staging
> > repository was added inside the POM xml since I didn't want to modify my
> > maven settings.xml. But we can change it..
> > 
> > The functional test project contains 2 profiles:
> > 
> >         1. arq-jbossas-managed-7
> >         2. arq-jbossas-remote
> > 
> > 
> > By default the first profile is active.
> > 
> > Inside the AerogearControllerDemoTestCase there is a TODO task which
> > states: 'TODO: uncomment when
> > https://issues.jboss.org/browse/AEROGEAR-1005 is fixed'. The relevant
> > commented code tests the above JIRA issue.
> > 
> > Any comment, enhancement, improvement is highly appreciated :)
> > 
> > Thank you,
> > Tolis Emmanouilidis
> > 
> > [1] https://github.com/tolis-e/aerogear-controller-demo.git
> 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20130323/9fe88ba3/attachment.html