As far as I recall (because we discussed it a long time ago). But I
think you are talking about the following piece of code, right? I think
the method below is still handy.
/**
* Role validation against the IDM
*
* @param roles roles to be checked
* @return returns true if the current logged in has roles at the
IDM, false otherwise
*/
@Override
public boolean hasRoles(Set<String> roles) {
if (identity.isLoggedIn()) {
for (String role : roles) {
Role retrievedRole = BasicModel.getRole(identityManager,
role);
if (retrievedRole != null &&
BasicModel.hasRole(partitionManager.createRelationshipManager(),
identity.getAccount(), retrievedRole)) {
return true;
}
}
}
return false;
}
Speaking about the interceptor, here comes some criticism about what I did:
private void authorize(Set<String> roles) {
boolean hasRoles = identityManagement.hasRoles(roles);
if (!hasRoles)
throw new
AeroGearSecurityException(HttpStatus.CREDENTIAL_NOT_AUTHORIZED);
}
The code above doesn't open a security flaw, but being completely
paranoid that should be refactored to authorize accept a single role (I
can be wrong). But think about the following scenario (out of the UPS
box). If the developer mistakenly add "simple", "admin" to the some
method (is not impossible) which does some sensitive operation, this
might be a problem.
As I told you guys, I'm not against it, but my job is to be picky and
raise some concerns. AG Sec is not the holy grail of security and must
be improved.
Sebastien Blanc wrote:
> But that is already something that we can do with AG PL , adding
> multiple roles to the secure annotation. You said we should maybe
> remove this from ag-pl ?
--
abstractj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
Url : http://lists.jboss.org/pipermail/aerogear-dev/attachments/20131105/c99915fd/attachment-0001.bin