[aerogear-dev] JavaScript formatter

[Sebastien Blanc]

On Tue, Oct 29, 2013 at 2:20 PM, Lucas Holmquist <lholmqui at redhat.com>wrote:

>
> On Oct 29, 2013, at 6:39 AM, Erik Jan de Wit <edewit at redhat.com> wrote:
>
> Hi,
>
> I saw that there was some discussion about whitespace in a javascript file
> on  a PR yesterday. Now it seems to me that among the things to discuss
> whitespace is just noise, especially because formatting can be done
> automatically.
>
>
> I think part of this was the fact that somethings didn't need to be
> revisioned.( some IDE's like to do stuff ).
>
>  I think it is important  as part of the commit process that we need to be
> making sure that we are only committing changes that we made.
>

+1 and I take entirely responsibility for this one. Auto format from IDEs
are evil. And running grunt without any warning should be a condition
before pushing.


>
>
> Talking with qmx and lholmquist about this it seems that JS land doesn't
> have good tools for this.
>
> To have something in the mean time we could use something like the eclipse
> formatter, because it can format JS has a ton of options and there are
> already a lot of external tools that use it:
>
> https://github.com/krasa/EclipseCodeFormatter
> https://code.google.com/p/maven-java-formatter-plugin
> http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/
>
> So how about having something like this that will format our JS for us? We
> could integrate something like this in our build, or that or create our own
> CLI tool as long as we have something that will work so that we don't have
> to discuss formatting anymore, what do you think?
>
> Cheers,
> Erik Jan
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20131029/e9ccf196/attachment.html