[aerogear-dev] [SPS-JS] navigator.setMessageHandler Vs navigator.mozSetMessageHandler

[Matthias Wessendorf]

On Thu, Feb 6, 2014 at 9:52 AM, Sebastien Blanc <scm.blanc at gmail.com> wrote:

>
>
>
> On Thu, Feb 6, 2014 at 9:45 AM, Matthias Wessendorf <matzew at apache.org>wrote:
>
>>
>>
>>
>> On Thu, Feb 6, 2014 at 9:42 AM, Sebastien Blanc <scm.blanc at gmail.com>wrote:
>>
>>> Hi,
>>> Mozilla specifies[1] a function called "mozSetMessageHandler" while we
>>> named this function "setMessageHandler" in our polyfill [2] . This is the
>>> handler for incoming push notifications.
>>>
>>> I'm not really a big fan of specific prefixes but again if we want to be
>>> really polyfill here, we should align.
>>>
>>
>> hrm, not sure - I think, eventually theirs will be ``setMessageHandler``
>> as well;
>>
>
> Yes, I should ping them on their list to have more details.
>
>>
>> Why not just setting a reference from ``mozSetMessageHandler `` to
>> ``setMessageHandler`` ? That way both would work, right ?
>>
> You mean defining both functions and calling setMessageHandler from
>  mozSetMessageHandler ?
>


No, just like:

navigator.setMessageHandler = function(..) {........}; /// what we have ATM
navigator.mozSetMessageHandler = navigator.setMessageHandler; // a reference




>>
>>> wdyt ?
>>>
>>> Seb
>>>
>>>
>>>
>>> [1]
>>> https://developer.mozilla.org/en-US/docs/Web/API/Navigator.mozSetMessageHandler
>>> [2]
>>> https://github.com/aerogear/aerogear-js/blob/master/src/simplepush/aerogear.simplepush.js#L152
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20140206/4b68f0ff/attachment.html