[aerogear-dev] AeroDoc: Show/Send leads - Geo map not showing agents near-by ?

[Sebastien Blanc]

On Mon, Feb 17, 2014 at 9:00 AM, Matthias Wessendorf <matzew at apache.org>wrote:

>
>
>
> On Mon, Feb 17, 2014 at 8:57 AM, Sebastien Blanc <scm.blanc at gmail.com>wrote:
>
>>
>>
>>
>> On Mon, Feb 17, 2014 at 8:53 AM, Matthias Wessendorf <matzew at apache.org>wrote:
>>
>>>
>>>
>>>
>>> On Mon, Feb 17, 2014 at 8:47 AM, Sebastien Blanc <scm.blanc at gmail.com>wrote:
>>>
>>>>
>>>>
>>>>
>>>> On Mon, Feb 17, 2014 at 8:42 AM, Matthias Wessendorf <matzew at apache.org
>>>> > wrote:
>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Mon, Feb 17, 2014 at 8:20 AM, Erik Jan de Wit <edewit at redhat.com>wrote:
>>>>>
>>>>>>
>>>>>> On 16 Feb,2014, at 19:06 , Matthias Wessendorf <matzew at apache.org>
>>>>>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I tried to play w/ the Geo support on AeroDoc, but there are some
>>>>>> issues.
>>>>>>
>>>>>> After I noticed that only 'john' (the admin) (see [1]) is able to
>>>>>> update the log/lat data, I was wondering about the next thing: Does the map
>>>>>> show where 'agents' are? (by lat/long?)
>>>>>>
>>>>>>
>>>>>> Didn't change the security setting, guess it was always the case that
>>>>>> only admins can update. If that is wrong we should change that.
>>>>>>
>>>>>
>>>>> Hrm, ok - perhaps Sebi knows more
>>>>>
>>>> Yeah, that is because of this
>>>> https://github.com/aerogear/aerogear-aerodoc-backend/blob/master/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java#L59
>>>> We should just override the update method with @Secure("simple")
>>>>
>>>
>>> You might wanna see here:
>>>
>>> https://github.com/aerogear/aerogear-aerodoc-backend/blob/master/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java#L115
>>>
>>
>> Doh ! I'm probably not enough wake up :)
>> Ok but then we should maybe flip the coin and protect the class with
>> "simple" and override the "admin" ones with "admin".
>>
>
> well, shouldn't it just work, w/ the override ? Let's first investigate if
> the source is really a bug, versus a wrong usage
>

Abstractj should confirm, but the override is not working this way, looking
at
https://github.com/aerogear/aerogear-security/blob/master/src/main/java/org/jboss/aerogear/security/interceptor/SecurityInterceptor.java#L54
it
first validates on class level before looking at the method and an
Exception will be thrown before it looks at the method annotation.


>
> -<
>
>
>>
>>
>>>
>>>
>>>
>>>>
>>>>>>
>>>>>>
>>>>>> I am not seeing an agent on my map:
>>>>>> http://people.apache.org/~matzew/geo-map.png
>>>>>>
>>>>>> That is not supported at the moment.
>>>>>>
>>>>>
>>>>> Too bad ;-) Would be a nice feature :-)
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> My long/lat values are OUTSIDE of that given radius (how can I change
>>>>>> the radius), but my location is INSIDE of the visible map.
>>>>>>
>>>>>>
>>>>>> You click the radius and drag the handle (little circle on the bottom
>>>>>> right) to increase the radius.
>>>>>>
>>>>>
>>>>> Ahhh!!!!! :-) I noticed that yesterday night :-) Almost an easter egg
>>>>> :-) pretty good hidden :) But I guess that's due to the map we use, right ?
>>>>>
>>>>
>>>> Yeah, the handle is not very visible in the first place, Erik, could we
>>>> change the style of this handle (more contrast, other color?)
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> Since a map is shown on that 'send leads' page, I was hoping to
>>>>>> actually see a mark for my location. Or is this just not supported, atm ?
>>>>>>
>>>>>>
>>>>>> right not supported, the idea is that you search sales agents that
>>>>>> are within the radius and send them the lead.
>>>>>>
>>>>>
>>>>> Not sure that works :-)
>>>>>
>>>>> I added a lead in San Francisco, and had my agent use my coordinates.
>>>>> I updated the radius (increased by a few meters), than I think the search
>>>>> results updated, but john (location data: Germany, Emsdetten) was showing
>>>>> up :-)
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> Greetings,
>>>>>> Matthias
>>>>>>
>>>>>>
>>>>>> [1] https://issues.jboss.org/browse/AGPUSH-535
>>>>>>
>>>>>> --
>>>>>> Matthias Wessendorf
>>>>>>
>>>>>> blog: http://matthiaswessendorf.wordpress.com/
>>>>>> sessions: http://www.slideshare.net/mwessendorf
>>>>>> twitter: http://twitter.com/mwessendorf
>>>>>> _______________________________________________
>>>>>> aerogear-dev mailing list
>>>>>> aerogear-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> aerogear-dev mailing list
>>>>>> aerogear-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matthias Wessendorf
>>>>>
>>>>> blog: http://matthiaswessendorf.wordpress.com/
>>>>> sessions: http://www.slideshare.net/mwessendorf
>>>>> twitter: http://twitter.com/mwessendorf
>>>>>
>>>>> _______________________________________________
>>>>> aerogear-dev mailing list
>>>>> aerogear-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> aerogear-dev mailing list
>>>> aerogear-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>
>>>
>>>
>>>
>>> --
>>> Matthias Wessendorf
>>>
>>> blog: http://matthiaswessendorf.wordpress.com/
>>> sessions: http://www.slideshare.net/mwessendorf
>>> twitter: http://twitter.com/mwessendorf
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20140217/17ba9c03/attachment-0001.html