[aerogear-dev] Safari Push notifications

Wed Nov 19 09:07:20 EST 2014

Hey Luke,

did a first review and also committed some minor tweaks to polish the
comments. First round -> done

On Fri, Nov 14, 2014 at 8:42 PM, Lucas Holmquist <lholmqui at redhat.com>
wrote:

> yea,  no problem, i was just wondering if there were thoughts on having 2
> selections or just 1.
>
> On Nov 14, 2014, at 2:35 PM, Matthias Wessendorf <matzew at apache.org>
> wrote:
>
> so far so good :-)
>
> It's just been a bit busy the last weeks... I will do a detailed review,
> and tests next week.
> Sounds good?
>
> On Fri, Nov 14, 2014 at 6:58 PM, Lucas Holmquist <lholmqui at redhat.com>
> wrote:
>
>>
>> On Nov 5, 2014, at 2:03 PM, Lucas Holmquist <lholmqui at redhat.com> wrote:
>>
>> so i wrote a little blog post on this,
>> http://blog.lholmquist.org/safari-push-notifications/
>>
>>
>> So i’ve made the iOSVariant an APNsVariant,  but now i have a decision.
>>
>> currently on the safari-push branch,
>> https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push,
>>  i’ve changed the UI to this:
>>
>>
>> http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05_at_11_09_49_AM.png
>>
>> where there is 1 variant to choose from for iOS and Safari.  And not
>> really and way to tell the difference if a variant is for safari or for iOS
>>
>> I’m wondering if there should be 2 selections that hit the same(update
>> from ios) “apns" endpoint, and also a field on the APNsVariant to
>> differentiate between iOS and Safari,  i can see this as being something
>> for analytics
>>
>> any thoughts on this?
>>
>>
>> If we agree to go this route,  then we can do the same when we update the
>> GCMVariant
>>
>>
>>
>>
>>
>>
>> On Oct 30, 2014, at 9:13 AM, Lucas Holmquist <lholmqui at redhat.com> wrote:
>>
>> hmm, indeed,  let me try that also
>>
>> On Oct 30, 2014, at 2:57 AM, Matthias Wessendorf <matzew at apache.org>
>> wrote:
>>
>> I tried the same, again with -d (rhc -d), that worked fine....
>>
>>
>> hrm...
>>
>> On Thu, Oct 30, 2014 at 7:48 AM, Matthias Wessendorf <matzew at apache.org>
>> wrote:
>>
>>> hahaha, than it disappeared ??? :-)
>>>
>>> looks like the 'delete' was triggered by the 504 ?
>>>
>>> On Thu, Oct 30, 2014 at 7:47 AM, Matthias Wessendorf <matzew at apache.org>
>>> wrote:
>>>
>>>> Here is what I did, on command line:
>>>> rhc app create --no-git safari "
>>>> https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/openshift-origin-cartridge-aerogear-push-wildfly&commit=086fe4f75f8991e7780c9df078c7371377c68aa2
>>>> "
>>>>
>>>>
>>>>
>>>> One the console, I am getting:
>>>> Creating application 'safari' ... Server returned an unexpected error
>>>> code: 504
>>>>
>>>>
>>>>
>>>>
>>>> but.... well, here is the server ->
>>>> https://safari-pushee.rhcloud.com/ag-push
>>>>
>>>>
>>>>
>>>> What I do not understand it the 504 :)
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf <
>>>> matzew at apache.org> wrote:
>>>>
>>>>> any log from rhc client?
>>>>>
>>>>>
>>>>> On Wednesday, October 29, 2014, Lucas Holmquist <lholmqui at redhat.com>
>>>>> wrote:
>>>>>
>>>>>> i’ve created a safari-push branch on my fork of the open shift
>>>>>> cartridge,
>>>>>>
>>>>>>
>>>>>> https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wildfly/tree/safari-push
>>>>>>
>>>>>>
>>>>>> i’ve been trying to create an app with it but haven’t been
>>>>>> successful,  perhaps something i’m doing,  anyone mind giving it a try
>>>>>>
>>>>>> On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui at redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> The branch on the main repo
>>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push
>>>>>>
>>>>>> subsequent PR’s will target this one
>>>>>>
>>>>>> On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui at redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>> Here is the initial addition in one of my branches:
>>>>>> https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push
>>>>>>
>>>>>> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew at apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui at redhat.com
>>>>>> > wrote:
>>>>>>
>>>>>>>
>>>>>>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit at redhat.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui at redhat.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>> So i’ve run into a bit of a problem, I’m trying to send
>>>>>>> notifications,  using
>>>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/APNsPushNotificationSender.java#L52
>>>>>>>
>>>>>>> but i’m not sure how to also tell it to use the new
>>>>>>> SafarVariant.class that i’ve created.
>>>>>>>
>>>>>>>
>>>>>>> Right now a sender is configured to send notifications for one
>>>>>>> specific variant type, this mapping is configured on the top of the class:
>>>>>>>
>>>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/APNsPushNotificationSender.java#L40
>>>>>>>
>>>>>>> so APNsPushNotificationSender will only be use for iOSVariant variants,
>>>>>>> so either we change the way this works or you create a new Sender ( that
>>>>>>> extends this one maybe )
>>>>>>>
>>>>>>>
>>>>>>> I think i’ll just create a new sender of now just to get something
>>>>>>> working since the SafariVariant and iOSVariant will be combined into an
>>>>>>> APNsVariant in the near future.
>>>>>>>
>>>>>>
>>>>>> sounds reasonable on getting this started
>>>>>>
>>>>>> -M
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Erik Jan
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> aerogear-dev mailing list
>>>>>>> aerogear-dev at lists.jboss.org
>>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> aerogear-dev mailing list
>>>>>>> aerogear-dev at lists.jboss.org
>>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Matthias Wessendorf
>>>>>>
>>>>>> blog: http://matthiaswessendorf.wordpress.com/
>>>>>> sessions: http://www.slideshare.net/mwessendorf
>>>>>> twitter: http://twitter.com/mwessendorf
>>>>>> _______________________________________________
>>>>>> aerogear-dev mailing list
>>>>>> aerogear-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> aerogear-dev mailing list
>>>>>> aerogear-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> aerogear-dev mailing list
>>>>>> aerogear-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Sent from Gmail Mobile
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matthias Wessendorf
>>>>
>>>> blog: http://matthiaswessendorf.wordpress.com/
>>>> sessions: http://www.slideshare.net/mwessendorf
>>>> twitter: http://twitter.com/mwessendorf
>>>>
>>>
>>>
>>>
>>> --
>>> Matthias Wessendorf
>>>
>>> blog: http://matthiaswessendorf.wordpress.com/
>>> sessions: http://www.slideshare.net/mwessendorf
>>> twitter: http://twitter.com/mwessendorf
>>>
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>  _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>

-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20141119/b6b6ab25/attachment-0001.html 