[aerogear-dev] Should Cordova push plugin dependencies be shrinkwrapped?

[Andrea Vibelli]

Absolutely yes :-), +1

Thanks
Andrea


gercan wrote
> Hi All,
> I have been working cordova push quickstarts and noticed that on Android
> installation through JBoss tools started to fail.
> 
> After a  bit of investigation  I figured that the failure occurs because
> push plugin defines cordova plugin "com.google.playservices" as a
> dependency through a git URL[1] that points to the master of the plugin's
> repo. Unfortunately this repo received a change [2] which started to use a
> new feature that was not implemented for JBoss tools. In this particular
> case, I am already implementing the missing feature so it should be all
> good soon. However I have doubts that referencing a dependency through
> master is a good idea. I think it may not only make it really difficult
> for
> us to reproduce cases but also unexpected behaviour may just appear.
> 
> 
> [1] https://github.com/MobileChromeApps/google-play-services
> [2]
> https://github.com/MobileChromeApps/google-play-services/commit/41c19152c21981c9a2f6497cc2100c317f5c660d
> 
> _______________________________________________
> aerogear-dev mailing list

> aerogear-dev at .jboss

> https://lists.jboss.org/mailman/listinfo/aerogear-dev





--
View this message in context: http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-Should-Cordova-push-plugin-dependencies-be-shrinkwrapped-tp9122p9156.html
Sent from the aerogear-dev mailing list archive at Nabble.com.