[aerogear-dev] Review process for aerogear PR's

Wojciech Trocki wtrocki at redhat.com
Tue Dec 13 12:19:46 EST 2016


Hi Aerogear Developers :)

Do you guys think that we can use github squash or merge option as default
action for aerogear digger repos (or even every aerogear repository)?

 Aerogear contribution guide doesn't state how tickets are reviewed etc.
but I see that most of the opensource projects use squashing option after
merging to master - this would still allow us to push as many commits as we
want. Squashing would be performed before merge to master on github. This
would make our git logs clean and would simplify releases etc.

I do not want to start some holly war here, but I would just like to keep
things clean and avoid some commits to repo without actual meaning or
simply incomplete. When checking changes on the master multiple commits can
make things difficult. It would be hard to provide some release notes
basing on that etc.

Regards

-- 
Wojciech Trocki
Software Engineer, Red Hat Mobile
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20161213/84f203f0/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.png
Type: image/png
Size: 11472 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/aerogear-dev/attachments/20161213/84f203f0/attachment.png 


More information about the aerogear-dev mailing list