[aerogear-dev] Google Service Gradle Plugin

[Summers Pittman]

On Mon, May 2, 2016 at 7:33 AM, Matthias Wessendorf <matzew at apache.org>
wrote:

>
>
> On Mon, May 2, 2016 at 12:53 PM, Summers Pittman <supittma at redhat.com>
> wrote:
>
>>
>>
>> On Mon, May 2, 2016 at 3:16 AM, Matthias Wessendorf <matzew at apache.org>
>> wrote:
>>
>>> sounds good to me, Summers.
>>>
>>> So, that means in AGDroind we aren't yet adding any support for the
>>> google-service.json file, but in later versions e.g. 3.x ?
>>>
>>
>> Well we can support it in documentation.  Basically we can replace where
>> we say "Sender ID" in the docs with "Sender ID
>> or getString(R.string.gcm_defaultSenderId)";  This way the dev an pick what
>> to use (plugin or no plugin).
>>
>
> That works for me.
>
> This also means no real code change on ADDroid 3.0.0.
>
> Do we still want to set the Sender ID field on the UPS UI as 'deprecated'?
> I think we should not do that yet, only once we have really started to the
> plugin (google's or our own)
>

I think in the UI we can mark it as "optional if using Google Services
Plugin" and change the generated code to show the sender ID or
"getString(R.string.gcm_defaultSenderId)" in the template depending on if
the sender ID is set or not.



>
> -Matthias
>
>
>>
>>
>>>
>>> On Sat, Apr 30, 2016 at 8:09 PM, Summers Pittman <supittma at redhat.com>
>>> wrote:
>>>
>>>> I'm fine with this. We might want to think about offering our own build
>>>> plugin in a future release
>>>> On Apr 30, 2016 7:23 AM, "Matthias Wessendorf" <matzew at apache.org>
>>>> wrote:
>>>>
>>>>> Or, we skip the plugin, and continue to rely on the sender_id /
>>>>> project_number, like now ?
>>>>>
>>>>> I think I am a bit sceptical if this plugin makes us go a route we
>>>>> perhaps don't want ?
>>>>>
>>>>> On Tue, Apr 26, 2016 at 3:14 AM, Matthias Wessendorf <
>>>>> matzew at apache.org> wrote:
>>>>>
>>>>>> How is the regerence impl. (gcm-playground) solving this?
>>>>>>
>>>>>>
>>>>>> On Monday, 25 April 2016, Summers Pittman <supittma at redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>> I am currently working on setting up support for consuming the
>>>>>>> google-services.json file for our AeroGear Android Push.  I can parse the
>>>>>>> file to extract the push values from it at runtime if the file is in the
>>>>>>> assets folder; however, the Google services plugin expects this to be in
>>>>>>> the project flavor root and thus outside of the classpath.
>>>>>>>
>>>>>>> What do you guys think?  Ideally we wouldn't be dependent on
>>>>>>> Google's plugin and would put this file in assets.  However if you use
>>>>>>> Google's services above and beyond push then we will either a) need to
>>>>>>> duplicate the file or b) intelligently detect if the plugin was used to
>>>>>>> build the project and consume the file as appropriate.
>>>>>>>
>>>>>>> Thoughts?
>>>>>>>
>>>>>>> Summers
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent from Gmail Mobile
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matthias Wessendorf
>>>>>
>>>>> blog: http://matthiaswessendorf.wordpress.com/
>>>>> sessions: http://www.slideshare.net/mwessendorf
>>>>> twitter: http://twitter.com/mwessendorf
>>>>>
>>>>> _______________________________________________
>>>>> aerogear-dev mailing list
>>>>> aerogear-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>
>>>>
>>>> _______________________________________________
>>>> aerogear-dev mailing list
>>>> aerogear-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>
>>>
>>>
>>>
>>> --
>>> Matthias Wessendorf
>>>
>>> blog: http://matthiaswessendorf.wordpress.com/
>>> sessions: http://www.slideshare.net/mwessendorf
>>> twitter: http://twitter.com/mwessendorf
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20160502/0f069be2/attachment-0001.html