[Aerogear-users] cordova push plugin.xml namespace

[Erik Jan de Wit]

fixed

On Tue, Jul 7, 2015 at 11:43 PM, Kelvin Lunsford <kelvin at qantel.com> wrote:

> Thanks Erik,
>
> The latest commit should fix the permission problem I was seeing.
>
> The plugin.xml file still has unneeded xmlns:android namespace attributes
> in elements on lines 35, 38, and 39.
>
> - Kelvin
>
>
> ------------------------------------------------------------------------------------
>
> From: aerogear-users-bounces at lists.jboss.org [mailto:
> aerogear-users-bounces at lists.jboss.org] On Behalf Of Erik Jan de Wit
> Sent: Tuesday, July 07, 2015 2:17 AM
> To: aerogear-users at lists.jboss.org
> Subject: Re: [Aerogear-users] cordova push plugin.xml namespace
>
> Right, good find! I've created a PR for this
> https://github.com/aerogear/aerogear-cordova-push/pull/72 maybe you can
> try it out?
>
> cordova plugin add
> https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix
>
> On Tue, Jul 7, 2015 at 2:59 AM, Kelvin Lunsford <kelvin at qantel.com> wrote:
> Can someone please modify plugin.xml so the xmlns:android namespace
> attribute is in the top-level element as specified in the plugin.xml
> documentation (
> https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html), and
> take the xmlns:android attributes out of the lower elements.
>
> If the namespace is not changed problems will occur when installing the
> push plugin along with any other plugin containing one of the push plugins
> android permissions (e.g. cordova-plugin-contacts uses GET_ACCOUNTS,
> cordova-plugin-wakeuptimer uses WAKE_LOCK).
>
> Cordova CLI can deal with the same android permission used by multiple
> plugins but will install an invalid extra copy of a permission if it
> includes a xmlns:android attribute.
>
> The android ACCESS_NETWORK_STATE permission was removed by aerogear in the
> latest release because of AGCORDOVA-72.  The cause of the AGCORDOVA-72
> problem was most likely the namespace problem.  The permission should not
> have been removed.
>
> - Kelvin
>
>
> _______________________________________________
> Aerogear-users mailing list
> Aerogear-users at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-users
>
>
>
>
> --
> Cheers,
>        Erik Jan
>
> _______________________________________________
> Aerogear-users mailing list
> Aerogear-users at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-users
>



-- 
Cheers,
       Erik Jan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-users/attachments/20150708/2bd876b7/attachment.html