[arquillian-issues] [JBoss JIRA] Commented: (ARQAJO-30) Rename URL object names in configuration names, modify URLUtils accordingly

Lukas Fryc (JIRA) jira-events at lists.jboss.org
Wed Feb 23 11:22:13 EST 2011


    [ https://issues.jboss.org/browse/ARQAJO-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584161#comment-12584161 ] 

Lukas Fryc commented on ARQAJO-30:
----------------------------------

You can sanitize input from user on Arq-Sel Extension side (simply by checking/adding slash on the end of contextPath).

Don't forget that from URL point of view, the slash on the end matters (it decides if URL stands for directory or file).

> Rename URL object names in configuration names, modify URLUtils accordingly
> ---------------------------------------------------------------------------
>
>                 Key: ARQAJO-30
>                 URL: https://issues.jboss.org/browse/ARQAJO-30
>             Project: Arquillian Ajocado
>          Issue Type: Enhancement
>            Reporter: Karel Piwko
>            Assignee: Lukas Fryc
>
> I find current URL object names (contextRoot and contextPath) a bit misleading.
> 1/ contextRoot and contextPath have same meaning as web application path, that is a part after authority's slash (/)  and before next slash
> e.g. for http://localhost:8080/foo/bar the contextPath and contextRoot is either /foo (contextPath), foo(context-root)
> in current version contextRoot = http://localhost:8080, contextPath = http://localhost:8080/foo
> With URLUtils it is not possible to create a path such as http://localhost:8080/foo/ , because new URL(context, spec) called as new URL(contextPath, "/") according to RFC3296 returns http://localhost:8080
> However, if contextPath was a string, it could be called as URLUtils(contextRoot, contextPath, "/"), not sure about slash between contextRoot and contextPath though.
> My suggestions:
> baseURL (http://localhost:8080/) - URL
> contextPath/contextRoot(/foo) - String
> fullURL (http://localhost:8080/foo) - URL

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the arquillian-issues mailing list