[arquillian-issues] [JBoss JIRA] (ARQ-322) Implement a GlassFish 3.1 managed container adapter
Dan Allen (JIRA)
jira-events at lists.jboss.org
Sun Mar 11 23:50:47 EDT 2012
[ https://issues.jboss.org/browse/ARQ-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675791#comment-12675791 ]
Dan Allen commented on ARQ-322:
-------------------------------
The refactorings look excellent. The module is now much more cohesive and DRY. I also like how concise the code is in the managed DeployableContainer. No lines wasted there :)
I sent a pull request with some minor refinements I recommend.
https://github.com/VineetReynolds/arquillian-container-glassfish/pull/1
Included in that review is an answer to the pending FIXME (in fact, I went ahead and fixed it).
One change I didn't make in the pull request, but recommend, is changing the name of the "clientutils" package in common. It's more than just utils, so I don't think it describes the package well. How about one of these names instead:
- org.jboss.arquillian.container.glassfish.client
- org.jboss.arquillian.container.glassfish.adminclient
I'll address the other points in the next comment.
> Implement a GlassFish 3.1 managed container adapter
> ---------------------------------------------------
>
> Key: ARQ-322
> URL: https://issues.jboss.org/browse/ARQ-322
> Project: Arquillian
> Issue Type: Feature Request
> Components: GlassFish Containers
> Affects Versions: glassfish_1.0.0.CR2
> Reporter: Dan Allen
> Assignee: Vineet Reynolds
>
> To round out the GlassFish support, we need a managed container adapter (see the JBoss AS managed container).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the arquillian-issues
mailing list