[arquillian-issues] [JBoss JIRA] (ARQ-1320) Warp - The NonWrittingResponse does not override the flushBuffer() method allowing for committing response.

[Jakub Narloch (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760041#comment-12760041 ] 

Jakub Narloch commented on ARQ-1320:
------------------------------------

I added all the methods from HttpServletResponse and ServletResponse that will eventually commit the response and made it unmodificable afterwards. The one more thing we need to consider is how the sendError(int, String) method should work. According to the docs, the methods can override the response stream and clear the headers, but more over it can affect the execution chain whenever there are error page defined in the web.xml

Also, there is one more thing we need to consider if the wrapper is commited, should we implement the rest of the methods according to the spec, so that there won't have any effect if the isCommitted() == true?
                
> Warp - The NonWrittingResponse does not override the flushBuffer() method allowing for committing response.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ARQ-1320
>                 URL: https://issues.jboss.org/browse/ARQ-1320
>             Project: Arquillian
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Extension - Warp
>    Affects Versions: warp_1.0.0.Alpha2
>            Reporter: Jakub Narloch
>            Priority: Blocker
>             Fix For: warp_1.0.0.Beta1
>
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
>
> The flushBuffer(http://docs.oracle.com/javaee/6/api/javax/servlet/ServletResponse.html#flushBuffer()) which causes the response to be marked as commited. and Adding afterwards any headers to the response has no effect.
> We should override the that method and prevent it's default behaviour.
> Also, it would be good idea to check the specs for any other method that could commit the message and prevent from enriching it by Warp.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira