[arquillian-issues] [JBoss JIRA] (ARQ-1320) Warp - The NonWrittingResponse does not override the flushBuffer() method allowing for committing response.

[Jakub Narloch (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760348#comment-12760348 ] 

Jakub Narloch commented on ARQ-1320:
------------------------------------

On second thought, I think that adding the sendError methods to the pull request was a bad idea. In fact sending error on the response can redirect to other web page depending on the web.xml <errorPage> mapping, which we can not imitiate in any way through the proxy. The only solution would be to invoke the that method on the actual response, but that would end up in returning a non HTTP 200 code from the server.
                
> Warp - The NonWrittingResponse does not override the flushBuffer() method allowing for committing response.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ARQ-1320
>                 URL: https://issues.jboss.org/browse/ARQ-1320
>             Project: Arquillian
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Extension - Warp
>    Affects Versions: warp_1.0.0.Alpha2
>            Reporter: Jakub Narloch
>            Priority: Blocker
>             Fix For: warp_1.0.0.Beta1
>
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
>
> The flushBuffer(http://docs.oracle.com/javaee/6/api/javax/servlet/ServletResponse.html#flushBuffer()) which causes the response to be marked as commited. and Adding afterwards any headers to the response has no effect.
> We should override the that method and prevent it's default behaviour.
> Also, it would be good idea to check the specs for any other method that could commit the message and prevent from enriching it by Warp.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira