[arquillian-issues] [JBoss JIRA] (ARQ-1561) Warp proxy tries to rewrite binary files

[Jan Dosoudil (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921874#comment-12921874 ] 

Jan Dosoudil commented on ARQ-1561:
-----------------------------------

I've attached files, there is not exception so I don't have stack trace, but corrupted files. Mime type is image/png.

My point of view is that new String(byte[]).getBytes() is system locale dependent and doesn't return same byte[] for Unicode locales. My opinion is that rewrite should be done on original byte[] (without new String(byte[])) and only for text/* mime types.
                
> Warp proxy tries to rewrite binary files
> ----------------------------------------
>
>                 Key: ARQ-1561
>                 URL: https://issues.jboss.org/browse/ARQ-1561
>             Project: Arquillian
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Extension - Warp
>    Affects Versions: 1.0.0.Alpha5
>            Reporter: Jan Dosoudil
>            Priority: Critical
>             Fix For: warp_1.0.0.Alpha6
>
>         Attachments: empty.png, empty2.png
>
>
> It's related to ARQ-1552 - rewrite calls new String(byte[]) on response byte[] which may fail on binary files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira