[arquillian-issues] [JBoss JIRA] (ARQ-1481) Remove redundancy of both ArquillianSputnik and ArquillianSpecification

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805451#comment-12805451 ] 

Aslak Knutsen commented on ARQ-1481:
------------------------------------

<aslak> kpiwko why remove @ArquillianSpecification? ARQ-1481
<aslak> kpiwko i thought that was 'the spock' way and not RunWith?
<aslak> (maybe that's only when you extend? )
<kpiwko> aslak: Sputnik does not have before/after suite events
<kpiwko> so there is no way how to bind there but using the same way as Arquillian JUnit does
<kpiwko> and for that, it is needed to have access to class constructor
<kpiwko> so a different runner
<kpiwko> I discussed that on spock ML
<kpiwko> but Peter didn't want to create such hooks
<kpiwko> or at least, not implemented this way...he was thking about aftershutdown hook
<aslak> kpiwko hmm, but wouldn't you be able to do the same in the ASpockExtension as you do in ASputnik?
<kpiwko> aslak: I don't think so...the AfterSuite hook is directly in run method
<kpiwko> and spock does not give you access to RunNotiifer anywhare in annotated extension
<aslak> kpiwko no, but it's only there because that's where we could hook in with junit. it basically runs After the last known test
<aslak> similar you could use setupSpec/cleanupSpec
<aslak> for each setupSpec +1 counter, for each cleanupSpec -1 counter. in cleanupSpec if counter == 0, fire AfterSuite
<aslak> same with in setupSpec if counter == 0 fire BeforeSuite
<kpiwko> that might work
<aslak> in spock you should be able to get away from the ThreadLocal State stuff as well, since you only hvae one Instance of the interceptor and can control the creation of TestRunnerAdapter internally
<kpiwko> aslak: that would be nice
                
> Remove redundancy of both ArquillianSputnik and ArquillianSpecification
> -----------------------------------------------------------------------
>
>                 Key: ARQ-1481
>                 URL: https://issues.jboss.org/browse/ARQ-1481
>             Project: Arquillian
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Spock TestRunner
>    Affects Versions: spock_1.0.0.Beta1
>            Reporter: Karel Piwko
>            Assignee: Karel Piwko
>
> It should be possible to remove @ArquillianSpecification, as it is redundant to @RunWith call.
> {code}
> @ArquillianSpecification
> @RunWith(ArquillianSputik)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira