[arquillian-issues] [JBoss JIRA] (ARQ-600) Improve Tomcat codebase - Managed

[Stephen Coy (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982246#comment-12982246 ] 

Stephen Coy commented on ARQ-600:
---------------------------------

I've just had a go at adding tomcat-managed-8 to this source base.

And now I can see that the remaining code in tomcat-managed-5.5 and tomcat-managed-6 is effectively identical - they both use "Servlet 2.5" protocol.

tomcat-managed-7 and tomcat-managed-8 both use "Servlet 3.0" protocol and use the same (overridden) deploy/undeploy/list commands.

ie. There's only two different flavours of tomcat-managed-N arquillian container integrations:
 * 5.5 and 6
 * 7 and 8

I'm thinking of moving all the java code into tomcat-managed-common and just leaving the unit tests in the tomcat-managed-N modules and building tomcat-managed-N.jars that just contain the appropriate org.jboss.arquillian.core.spi.LoadableExtension file.

What do you think?


> Improve Tomcat codebase - Managed
> ---------------------------------
>
>                 Key: ARQ-600
>                 URL: https://issues.jboss.org/browse/ARQ-600
>             Project: Arquillian
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Tomcat Containers
>            Reporter: Aslak Knutsen
>            Assignee: Stephen Coy
>             Fix For: tomcat_1.0.0.Final
>
>
> After the Tomcat Container code clean up, tomcat-common, it seems all the Managed Tomcat containers are identical both in impl and configuration. 
> We can create a similar tomcat-common-managed that will have the common parts between the different versions.
> {note}
> If Tomcat Managed 5.5, 6 and 7 are identical, why do we have 3 versions? 
> {note}



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)