[arquillian-issues] [JBoss JIRA] (ARQ-1874) Allow Drone to skip session file creation

[Matous Jobanek (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090822#comment-13090822 ] 

Matous Jobanek commented on ARQ-1874:
-------------------------------------

I wasn't able to reproduce this bug. Actually, in case when the remoteReusable property is not set I don't see any way how the session file could be created.
The file is created in this method:
https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-webdriver/src/main/java/org/jboss/arquillian/drone/webdriver/factory/remote/reusable/ReusedSessionPermanentFileStorage.java#L94-L100
that is called only if the PersistReusedSessionsEvent is fired. This event is fired from one place only:
https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-webdriver/src/main/java/org/jboss/arquillian/drone/webdriver/factory/RemoteWebDriverFactory.java#L138
This code is reachable when the InitializationParametersMap has a sessionId as a key:
https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-webdriver/src/main/java/org/jboss/arquillian/drone/webdriver/factory/RemoteWebDriverFactory.java#L133-L135
however the key sessionId is added only in the method:
https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-webdriver/src/main/java/org/jboss/arquillian/drone/webdriver/factory/RemoteWebDriverFactory.java#L153
and calling of this method is dependent on the condition {{configuration.isRemoteReusable()}}: 
https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-webdriver/src/main/java/org/jboss/arquillian/drone/webdriver/factory/RemoteWebDriverFactory.java#L97-L98

So, from the structure of the code it seems that it behaves as expected. Maybe I'm missing something...


> Allow Drone to skip session file creation
> -----------------------------------------
>
>                 Key: ARQ-1874
>                 URL: https://issues.jboss.org/browse/ARQ-1874
>             Project: Arquillian
>          Issue Type: Bug
>          Components: Extension - Drone
>    Affects Versions: drone_2.0.0.Alpha2
>            Reporter: Karel Piwko
>             Fix For: drone_2.0.0.Alpha5
>
>
> It should be possible not to touch filesystem and avoid creating session file if user wishes to do so.
> Storage should be completely ignored if remoteReusable is not set.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)