[arquillian-issues] [JBoss JIRA] (ARQGRA-480) Screenshooter - When "takeOnEveryAction" is activated then "takeBeforeTest" seems to be activated as well

[Lukáš Fryč (JIRA)]

    [ https://issues.jboss.org/browse/ARQGRA-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114766#comment-13114766 ] 

Lukáš Fryč commented on ARQGRA-480:
-----------------------------------

I can see two issues reported as one:

a) configuration doesn't work as expected (as indicated by printed configuration summary)

b) you suggest enhancing the behavior by making it more "smart" (either (1) or (2)), but I can see one can already achieve the desired solution by expressing when he wants to take screenshots

I would suggest to leave configuration options as they are but making them follow the arquillian.xml configuration (no additional activation logic).

> Screenshooter - When "takeOnEveryAction" is activated then "takeBeforeTest" seems to be activated as well
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: ARQGRA-480
>                 URL: https://issues.jboss.org/browse/ARQGRA-480
>             Project: Arquillian Graphene
>          Issue Type: Bug
>          Components: screenshooter
>    Affects Versions: 2.1.0.Alpha2
>            Reporter: Matous Jobanek
>             Fix For: 2.1-Tracking
>
>
> Consider this scenario:
> Arquillian.xml contains:
> {code:xml}
> <extension qualifier="screenshooter">
>         <property name="takeOnEveryAction">true</property>
>         <property name="takeBeforeTest">false</property>
>         <property name="takeAfterTest">false</property>
>         <property name="takeWhenTestFailed">false</property>
>     </extension>
> {code}
> Then, when the test starts this output is written there in the console log:
> {noformat}
> Configuration of Arquillian Browser Screenshooter:
> rootDir                                  target/screenshots
> screenshotType                           PNG
> takeBeforeTest                           true
> takeAfterTest                            false
> takeWhenTestFailed                       false
> takeOnEveryAction                        true
> {noformat}
> There is written {{takeBeforeTest     true}} which can be confusing, because it is not activated there in the arquillian.xml. This output should reflect what is set there.
> The second thing is that the {{_before}} screenshot is taken when takeOnEveryAction is activated. However, neither {{_after}} nor {{_failed}} is taken. This is confusing as well - I would expect some consistency. I'm suggesting two options how to solve this:
> 1) take screenshots only on every interaction with the WebDriver object (as it is written in the [README|https://github.com/MatousJobanek/arquillian-graphene/tree/ARQ-1979_tests/extension/screenshooter#arquillian-browser-screenshooter]) - this means not taking screenshots during the before phase
> 2) take screenshots on every action at all - this means not only on every interaction with the WebDriver but also during before, after and when the test fails



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)