[arquillian-issues] [JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml

[Gerhard Poul (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13311086#comment-13311086 ] 

Gerhard Poul commented on ARQ-2051:
-----------------------------------

How are you downloading the liberty instance from Maven? If you're using the liberty:create-server goal it already provides an option for a configFile like we packaged it in our wlp-managed-85 test.

Why is this more useful than that? I would think that if we start adding this, we will need further changes to support other features as well and at that point it just might be easier to include the server.xml as part of the test in the first place anyway; What do you think?

> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
>                 Key: ARQ-2051
>                 URL: https://issues.jboss.org/browse/ARQ-2051
>             Project: Arquillian
>          Issue Type: Feature Request
>          Components: WebSphere Containers
>    Affects Versions: was_1.0.0.Beta2
>            Reporter: arjan tijms
>            Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)