[arquillian-issues] [JBoss JIRA] (ARQ-2051) Add ability to add localconnector feature automatically to server.xml

[arjan tijms (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13311727#comment-13311727 ] 

arjan tijms commented on ARQ-2051:
----------------------------------

Thanks for looking into the PR Gerhard.

I was seeing the {{com.ibm.websphere.application.ApplicationMBean}} indeed. The java version I used for the test was:

{noformat}
java -version
java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)
{noformat}

Liberty version is the latest from Maven; 16.0.0.3. OS is OS X.

For the test I used the Soteria project (https://github.com/javaee-security-spec/soteria) where I removed the ant runt plug-in from line 409 onwards, see: https://github.com/javaee-security-spec/soteria/blob/master/test/pom.xml#L409

Then with the Liberty managed container that incorporated the PR installed I did:

{noformat}
mvn clean test install -Pliberty,bundled
{noformat}

_(just "install" should be sufficient but that was the exact command used)_

So it's a "plain" Liberty install without using Docker, wrecker or the Liberty maven plug-in.

Hope this helps.

> Add ability to add localconnector feature automatically to server.xml
> ---------------------------------------------------------------------
>
>                 Key: ARQ-2051
>                 URL: https://issues.jboss.org/browse/ARQ-2051
>             Project: Arquillian
>          Issue Type: Feature Request
>          Components: WebSphere Containers
>    Affects Versions: was_1.0.0.Beta2
>            Reporter: arjan tijms
>            Assignee: Gerhard Poul
>
> For the managed container for Liberty to connect to a liberty instance, the {{localConnector-1.0}} feature needs to be present in {{server.xml}}.
> This is somewhat of an obstacle when using a CI managed Liberty, where a Liberty instance is downloaded and installed from Maven during the test. Following the work done in ARQ-1729 it should be relatively easy to add this {{localConnector-1.0}} feature to {{server.xml}}.
> I would like to propose adding a new boolean to the configuration for the managed Liberty container, and when set to true the Arquillian container will add the mentioned feature and will thus be able to start Liberty without requiring the user to modify the installation first.
> (I'll look into doing a PR for this)



--
This message was sent by Atlassian JIRA
(v7.2.2#72004)