[arquillian-issues] [JBoss JIRA] (ARQ-2152) Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
Gordon Hutchison (JIRA)
issues at jboss.org
Thu Nov 16 09:28:00 EST 2017
[ https://issues.jboss.org/browse/ARQ-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490860#comment-13490860 ]
Gordon Hutchison edited comment on ARQ-2152 at 11/16/17 9:27 AM:
-----------------------------------------------------------------
An example arquillian.xml (tck/src/test/resources/arquillian.xml) that sets this element into server.xml is (look for apiTypeVisibility")
{code:java}
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<!-- Licensed under the Apache License, Version 2.0 (the "License"); you
may not use this file except in compliance with the License. You may obtain
a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
required by applicable law or agreed to in writing, software distributed
under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES
OR CONDITIONS OF ANY KIND, either express or implied. See the License for
the specific language governing permissions and limitations under the License. -->
<arquillian xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="http://jboss.org/schema/arquillian"
xsi:schemaLocation="http://jboss.org/schema/arquillian http://jboss.org/schema/arquillian/arquillian_1_0.xsd">
<defaultProtocol type="Servlet 3.0" />
<engine>
<property name="deploymentExportPath">target/</property>
</engine>
<container qualifier="websphere" default="true">
<configuration>
<property name="wlpHome">/work/liberty/src/libertyGit/open-liberty/dev/build.image/wlp</property>
<property name="serverName">server1</property>
<property name="httpPort">9080</property>
<property name="allowConnectingToRunningServer">true</property>
<property name="deployType">xml</property>
<property name="apiTypeVisibility">spec, ibm-api, third-party</property>
</configuration>
</container>
</arquillian>
{code}
was (Author: hutchig):
An example arquillian.xml (tck/src/test/resources/arquillian.xml) that sets this elelement into server.xml is:
{code:java}
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<!-- Licensed under the Apache License, Version 2.0 (the "License"); you
may not use this file except in compliance with the License. You may obtain
a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
required by applicable law or agreed to in writing, software distributed
under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES
OR CONDITIONS OF ANY KIND, either express or implied. See the License for
the specific language governing permissions and limitations under the License. -->
<arquillian xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="http://jboss.org/schema/arquillian"
xsi:schemaLocation="http://jboss.org/schema/arquillian http://jboss.org/schema/arquillian/arquillian_1_0.xsd">
<defaultProtocol type="Servlet 3.0" />
<engine>
<property name="deploymentExportPath">target/</property>
</engine>
<container qualifier="websphere" default="true">
<configuration>
<property name="wlpHome">/work/liberty/src/libertyGit/open-liberty/dev/build.image/wlp</property>
<property name="serverName">server1</property>
<property name="httpPort">9080</property>
<property name="allowConnectingToRunningServer">true</property>
<property name="deployType">xml</property>
<property name="apiTypeVisibility">spec, ibm-api, third-party</property>
</configuration>
</container>
</arquillian>
{code}
> Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
> ----------------------------------------------------------------------------------------------
>
> Key: ARQ-2152
> URL: https://issues.jboss.org/browse/ARQ-2152
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.next
> Environment: Testing Microprofile TCKs on WebSphere Liberty
> (Apologies for setting the priority.)
> (Apologies if the version is incorrect for https://github.com/arquillian/arquillian-container-was/tree/master/wlp-managed-8.5
> Reporter: Gordon Hutchison
> Assignee: Gerhard Poul
> Priority: Minor
>
> (I have to thank my colleague Kevin Grigorenko for this patch which I integrated into
> my local clone. The text below is pasted from text written by him: )
> "Added support for injecting a Tracer into the TCK: For the CDI injection to work, the TCK application's classloader must be configured with apiTypeVisibility="spec, ibm-api, third-party". The WAS Arquillian container's default deployType is dropins and I couldn't find a way to configure the classloader for that. The WAS Arquiallian container also supports deployType=xml which puts the WAR into apps and dynamically adds configuration to Liberty's server.xml with the <application /> element and some sub-elements. I forked that code to also add support for apiTypeVisibility and also submitted a pull request. Now, running with that fork and specifying <property name="deployType">xml</property> and <property name="apiTypeVisibility">spec, ibm-api, third-party</property> in mpOpentracingTckRunner/tck/src/test/resources/arquillian.xml allows the TCK to inject the Tracer."
> This WLP feature is discussed here:
> https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websphere.wlp.doc/ae/twlp_classloader_3p_apis.html
> I have Kevin's code patch that does this and am only raising this issue
> in order to reference it in a pull request I am going to make
> at
> https://github.com/arquillian/arquillian-container-was/tree/master/wlp-managed-8.5/src/main/java/org/jboss/arquillian/container/was/wlp_managed_8_5
> I have checked with Kevin that he is happy for me to do this:
> (On IBM Sametime)
> gordon_hutchison at uk.ibm.com - Gordon Hutchison/UK/IBM:
> 4:17:28 PM: Hi Kevin, is it OK with you if I create an issue and then a PR to integrate the 'apiTypeVisibility' change you did to the public upstream repo?
> Kevin GRIGORENKO:
> 4:17:54 PM: Yes, absolutely. Thanks very much!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
More information about the arquillian-issues
mailing list