From issues at jboss.org Thu Jan 3 06:21:00 2019 From: issues at jboss.org (Ladislav Thon (Jira)) Date: Thu, 3 Jan 2019 06:21:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2202) Include org.hamcrest out of box In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677931#comment-13677931 ] Ladislav Thon commented on ARQ-2202: ------------------------------------ My understanding is that JUnit 4 _requires_ Hamcrest to be present, otherwise loading some JUnit classes fails. TestNG doesn't have such dependency on Hamcrest, which is why Arquillian's {{TestNGDeploymentAppender}} doesn't (and IMHO shouldn't) automatically include it. > Include org.hamcrest out of box > ------------------------------- > > Key: ARQ-2202 > URL: https://issues.jboss.org/browse/ARQ-2202 > Project: Arquillian > Issue Type: Bug > Components: Build Infrastructure > Environment: n/a > Reporter: Emily Jiang > Priority: Major > > At the moment, if I want to use org.hamcrest, I have to package the classes on my own. I think it will be great if the class TestNGDeploymentAppender adds org.hamcrest classes automatically. It will be great. By the way, I think in junit, org.hamcrest classes are accessible out of box. I think TestNG should match that. -- This message was sent by Atlassian Jira (v7.12.1#712002) From issues at jboss.org Wed Jan 9 03:36:00 2019 From: issues at jboss.org (Thomas Diesler (Jira)) Date: Wed, 9 Jan 2019 03:36:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2201) arquillian-container-karaf-managed can not start the karaf server with JDK9+ In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679742#comment-13679742 ] Thomas Diesler commented on ARQ-2201: ------------------------------------- This project does currently not support Karaf-4.2 and AFAICS there are various other issues related to JDK9+ I'm happy to verify a PR that updates to the latest Karaf and addresses theses issues. Otherwise I suggest you switch to whatever test framework Karaf is using. The JBoss-OSGi effort, which this was part of, stopped many years ago. > arquillian-container-karaf-managed can not start the karaf server with JDK9+ > ---------------------------------------------------------------------------- > > Key: ARQ-2201 > URL: https://issues.jboss.org/browse/ARQ-2201 > Project: Arquillian > Issue Type: Bug > Components: OSGi Containers > Reporter: Amos Feng > Assignee: Thomas Diesler > Priority: Major > > Karaf support the JDK9+ since 4.2.0 but when starting with the arquillian the error is > {noformat} > -Djava.endorsed.dirs=/path/to/apache-karaf-minimal-4.2.0/lib/endorsed is not supported. > {noformat} > The possible fix could be with [KarafManagedDeployableContainer.java|https://github.com/arquillian/arquillian-container-osgi/blob/master/container/karaf/managed/src/main/java/org/jboss/arquillian/container/osgi/karaf/managed/KarafManagedDeployableContainer.java#L119] and should not pass the "-Dendorsed" argument when the JDK version >= 9 -- This message was sent by Atlassian Jira (v7.12.1#712002) From issues at jboss.org Wed Jan 9 03:36:00 2019 From: issues at jboss.org (Thomas Diesler (Jira)) Date: Wed, 9 Jan 2019 03:36:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2201) arquillian-container-karaf-managed can not start the karaf server with JDK9+ In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Diesler reassigned ARQ-2201: ----------------------------------- Assignee: (was: Thomas Diesler) > arquillian-container-karaf-managed can not start the karaf server with JDK9+ > ---------------------------------------------------------------------------- > > Key: ARQ-2201 > URL: https://issues.jboss.org/browse/ARQ-2201 > Project: Arquillian > Issue Type: Bug > Components: OSGi Containers > Reporter: Amos Feng > Priority: Major > > Karaf support the JDK9+ since 4.2.0 but when starting with the arquillian the error is > {noformat} > -Djava.endorsed.dirs=/path/to/apache-karaf-minimal-4.2.0/lib/endorsed is not supported. > {noformat} > The possible fix could be with [KarafManagedDeployableContainer.java|https://github.com/arquillian/arquillian-container-osgi/blob/master/container/karaf/managed/src/main/java/org/jboss/arquillian/container/osgi/karaf/managed/KarafManagedDeployableContainer.java#L119] and should not pass the "-Dendorsed" argument when the JDK version >= 9 -- This message was sent by Atlassian Jira (v7.12.1#712002) From issues at jboss.org Tue Jan 15 09:07:04 2019 From: issues at jboss.org (Rich DiCroce (Jira)) Date: Tue, 15 Jan 2019 09:07:04 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2203) Regression: Memory leak in DeploymentContextImpl.stores In-Reply-To: References: Message-ID: Rich DiCroce created ARQ-2203: --------------------------------- Summary: Regression: Memory leak in DeploymentContextImpl.stores Key: ARQ-2203 URL: https://issues.jboss.org/browse/ARQ-2203 Project: Arquillian Issue Type: Bug Components: core Affects Versions: 1.4.0.Final Reporter: Rich DiCroce DeploymentContexts are never destroyed. This creates a memory leak and can lead to OOME due to heap exhaustion. This was previously reported as ARQ-1949. Comments on that issue indicate it was fixed somewhere between 1.1.7 and 1.1.13. The final comment cites ARQ-1992, but the fix for that issue doesn't appear related to this problem at all. In any case, if this was fixed, it has since regressed. AFAICT there is no code that ever calls DeploymentContext#destroy() anywhere in Arquillian. For anyone else affected by this issue, there is a workaround. Create a LoadableExtension that properly destroys the deployment after it is no longer needed: {code} public class ArquillianLeakFix implements LoadableExtension { @Override public void register(ExtensionBuilder builder) { builder.observer(DeploymentDestroyer.class); } public static class DeploymentDestroyer { @Inject private Instance deploymentContext; public void destroyDeployment(@Observes(precedence = Integer.MIN_VALUE) final UnDeployDeployment event) { deploymentContext.get().destroy(event.getDeployment()); } } } {code} -- This message was sent by Atlassian Jira (v7.12.1#712002)