[bv-dev] Renaming ExecutableDescriptor#areParametersConstrained()?

[Rich Midwinter]

Ah. I was reading isParameterConstrained as the singular executable
constrained by parameters… which makes a lot less sense now than it seemed
to earlier! Another one in favour of hasConstrainedParameters() then.


On Thursday, 28 February 2013, Emmanuel Bernard <emmanuel at hibernate.org>
wrote:
> hasConstrainedParameters() is better that the current situation.
> But then we also need to move to hasConstrainedReturnValue().
>
> https://hibernate.onjira.com/browse/BVAL-432
>
> Rich, we could not find a use case for ExecutableDescriptor hosting
> isExecutableConstrained() and the singular isParameterConstrained does
> not work here as we are looking at the method aggregating all params
> for a given executable.
>
> Emmanuel
>
> On Thu 2013-02-28 10:06, Matt Benson wrote:
>> My vote is for #hasConstrainedParameters().
>>
>> Thanks,
>> Matt
>>
>>
>> On Thu, Feb 28, 2013 at 7:59 AM, Rich Midwinter <rich.midwinter at gmail.com
>wrote:
>>
>> > Perhaps worth mentioning we have BeanDescriptor#isBeanConstrained()
too in
>> > 1.0. So at first glance I'd probably suggest isParameterConstrained()
and
>> > also isExecutableConstrained().
>> >
>> > Rich
>> >
>> >
>> > On Thursday, 28 February 2013, Gunnar Morling <gunnar at hibernate.org>
>> > wrote:
>> > > Hi all,
>> > > Hardy and I were wondering whether the method
>> > name ExecutableDescriptor#areParametersConstrained() is the best
choice.
>> > > The name seems a bit unintuitive, when e.g. looking via
auto-completion
>> > for boolean getter methods which typically start with "is" or "has".
Maybe
>> > > * "isParameterConstrained()" (as in "is constrained on at least one
>> > parameter") or
>> > > * "hasConstrainedParameters()" would be better alternatives?
>> > >
>> > > The latter would also nicely match with
>> > BeanDescriptor#hasConstrainedExecutables().
>> > > WDYT?
>> > > --Gunnar
>> > >
>> >
>> > _______________________________________________
>> > beanvalidation-dev mailing list
>> > beanvalidation-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
>> >
>
>> _______________________________________________
>> beanvalidation-dev mailing list
>> beanvalidation-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
>
> _______________________________________________
> beanvalidation-dev mailing list
> beanvalidation-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/beanvalidation-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/beanvalidation-dev/attachments/20130228/fe3a0078/attachment.html