[bv-dev] Bean Validation 1.1 -> 2.0 review

[Gunnar Morling]

Thanks! PR addressing your remarks is coming up.

2017-06-02 9:35 GMT+02:00 Emmanuel Bernard <emmanuel at hibernate.org>:
> Hey all
>
> I could not do much but I promised Gunnar to review one last time the 1.1 ->
> 2.0 diff
> http://beanvalidation.org/2.0/spec/2.0.0.beta2/diff/diff-to-1.1/
>
> I did not find much and dod not checked it all but here is at least a few
> things
>
> Example 3.10: Multi-valued constraint declaration using explicit @List
> annotation
> I’d put in the example title that it is a discouraged pattern

Ok.

>
> 3.3
> "composing constraints are directly given on the composed constraint” ->
> "composing constraints are directly given on the composed constraint (i.e.
> via the repeatable annotation feature)"

Ok.
>
> "refers to the left-to-right order” -> I got puzzled by that one especially
> as we can put them on new lines. I would say “refers to the order in which
> they are declared”

"left-to-right-order" is a term used by the JLS, I think it's fine to
use it here as well.

>
> Example 3.21 / 3.24
> I find it odd to ahve the private method return null
> Can we make it a full example?

Ok, this example was pre-existing from 1.x times :) Replacing it with
a complete example.

>
> 4.1 add an exemple of non generic container usage maybe

There is an example for this (OptionalInt) in 4.4 (which contains all
the examples for this chapter).

>
> 4.4
> A value extractor for java.util.Optional:
> Maybe a comment reminding that the null is passed to have no path node entry

Ok.

>
> Maybe more to come later
>
> Emmanuel
>
> _______________________________________________
> beanvalidation-dev mailing list
> beanvalidation-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/beanvalidation-dev