[cdi-dev] [JBoss JIRA] (CDI-149) AnnotationLiteral in the CDI API does not cache the hashCode

Marko Lukša (JIRA) jira-events at lists.jboss.org
Wed Aug 15 16:23:15 EDT 2012

     [ https://issues.jboss.org/browse/CDI-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marko Lukša updated CDI-149:

    Git Pull Request: https://github.com/jboss/cdi/pull/64

Please review the pull request.

I've implemented the caching even for annotations with members. I don't think anyone, who understands what an AnnotationLiteral is, would implement a mutable concrete AnnotationLiteral. 

Maybe the javadoc of AnnotationLiteral should clearly state that member values must be constant.
> AnnotationLiteral in the CDI API does not cache the hashCode
> ------------------------------------------------------------
>                 Key: CDI-149
>                 URL: https://issues.jboss.org/browse/CDI-149
>             Project: CDI Specification Issues
>          Issue Type: Bug
>          Components: Javadoc and API
>    Affects Versions: 1.0
>            Reporter: Stuart Douglas
>            Assignee: Marko Lukša
>             Fix For: 1.1 (Proposed)
> Instead it is calculated each time using reflection, which could result in performance problems if lots of annotation literals are in use

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the cdi-dev mailing list