[cdi-dev] [JBoss JIRA] (CDI-504) have a standard CDI annotation like @ConfigProperty from deltapsike

Romain Manni-Bucau (JIRA) issues at jboss.org
Mon Feb 9 04:17:49 EST 2015


    [ https://issues.jboss.org/browse/CDI-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038675#comment-13038675 ] 

Romain Manni-Bucau edited comment on CDI-504 at 2/9/15 4:17 AM:
----------------------------------------------------------------

+1 with few minors notes:

- @Env and @SystemProperty maybe (instead of EnvProperty) to match JVM naming (@Property would be less meaningful IMO)
- conversion should be defined on a close set of types (primitives, wrapper + few java.lang/java.util + Collection + Map only) to ensure portability - not sure it is matre enough to support a good SPI ATM and if then it shouldnt be in config spec tamaya tries to prepare.

wdyt?


was (Author: rmannibucau):
+1 with few (minors notes):

- @Env and @SystemProperty maybe (instead of EnvProperty) to match JVM naming (@Property would be less meaningful IMO)
- conversion should be defined on a close set of types (primitives, wrapper + few java.lang/java.util + Collection + Map only) to ensure portability - not sure it is matre enough to support a good SPI ATM and if then it shouldnt be in config spec tamaya tries to prepare.

wdyt?

> have a standard CDI annotation like @ConfigProperty from deltapsike
> -------------------------------------------------------------------
>
>                 Key: CDI-504
>                 URL: https://issues.jboss.org/browse/CDI-504
>             Project: CDI Specification Issues
>          Issue Type: Feature Request
>            Reporter: James Strachan
>
> Docker and containerisation is the new hotness; in the docker world images are static and the main way of injecting configuration is via environment variables - so that the same image can be reused but configured at run time with different configuration values. (Changing configuration files requires either different images to be created or using custom volumes which is less ideal in a containerized world).
> So IMHO CDI should provide a simple, natural way to allow environment variables (or system properties) to be easily injected via CDI.
> Delta Spike as a @ConfigProperty annotation which works very nicely
> http://deltaspike.apache.org/documentation/configuration.html
> you can specify a name, default value and use it on an @Inject to provide a value from env vars, system properties or provide a default.
> Given how core and useful this is - it feels like it should be part of the CDI specification; its one simple annotation.
> Currently deltaspike provides a way to configure different sources and whatnot which is cool; I'd be happy if CDI just had a simpler annotation which was only bound to env vars / system properties. 
> e.g. @EnvironmentProperty(name = "envvar", deafultValue="cheese")
> There could be debate on whether env vars or system properties should win if the same name is used for both; in a dockerized world I'd prefer env vars to win but folks can always tinker with their run command to make sure they pass in env vars as system properties to work around this I guess.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)


More information about the cdi-dev mailing list