[cdi-dev] [JBoss JIRA] (CDI-514) FireEventTest#testDuplicateBindingsToFireEventFails() is wrong

[Tomas Remes (JIRA)]

    [ https://issues.jboss.org/browse/CDI-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046030#comment-13046030 ] 

Tomas Remes edited comment on CDI-514 at 3/4/15 2:56 AM:
---------------------------------------------------------

This should be TCK issue right? Yes the instances are not equal but the types are so it seems to me fine. It reflects given assertion IMO. 


was (Author: tremes):
This should be TCK issue right? Yes the instances are not equal but the types are so it seems to fine. It reflects given assertion IMO. 

> FireEventTest#testDuplicateBindingsToFireEventFails() is wrong
> --------------------------------------------------------------
>
>                 Key: CDI-514
>                 URL: https://issues.jboss.org/browse/CDI-514
>             Project: CDI Specification Issues
>          Issue Type: Clarification
>    Affects Versions: 1.2.Final
>            Reporter: Mark Struberg
>
> testDuplicateBindingsToFireEventFails() tests for 2 Lifted literals with different values. But this is perfectly fine as value is NOT annotated as @Nonbinding. Thus the 2 literals are NOT equals according to CDI rules. They are essentially 2 different annotations...
> Plz remove this test. It also makes no sense to add all those very performance costly tests at runtime. The worst case which can happen is that the 2 annotations make no sense. But they don't break anything. Wheras checking all the nasty conditions each and every time is really mad from a performance aspect. 



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)