[cdi-dev] [JBoss JIRA] (CDI-535) cdi instance injection ordering

[Martin Kouba (JIRA)]

    [ https://issues.jboss.org/browse/CDI-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13302950#comment-13302950 ] 

Martin Kouba commented on CDI-535:
----------------------------------

[~meetoblivion] [~gastaldi] I don't think {{@Priority}} would introduce a misuse here: 
{quote}
The Priority annotation can be applied to classes to indicate in what order the classes should be used. The effect of using the Priority annotation in any particular instance is defined by other specifications that define the use of a specific class.
{quote}
But as I said we would not be able to add priority to producer methods and fields. So it's -1.

A new annotation might work as well. {{OrderBy}} would be mixed up with {{javax.persistence.OrderBy}}.

bq. Even then, if you have multiple beans, all from the same field...
How could that happen? 


> cdi instance injection ordering
> -------------------------------
>
>                 Key: CDI-535
>                 URL: https://issues.jboss.org/browse/CDI-535
>             Project: CDI Specification Issues
>          Issue Type: Feature Request
>          Components: Beans
>    Affects Versions: 2.0 (discussion)
>            Reporter: Ochieng Marembo
>            Priority: Optional
>
> We should allow ordering of bean instance injection using the {{Instance<MyBeanInterface>}} when an instance injection is used.
> h3. Use case:
> Developer always define a kind of chain of processor beans, which may need to run in specific order.
> h3. Current scenario:
> Using the Instance injection mechanism, a developer can inject multiple beans implementing the same interface and iterate of them. In order to ensure ordering, the developer could do one of the following:
> #1
> {code:java}
> private Iterable<MyBeanInterface> myBeans;
> @Inject
> void injectBeans(@Any Instance<MyBeanInterface> myBeans) {
>   //the create order does some kind of ordering on the beans.
>    this.myBeans = createOrder(myBeans);
> }
> {code}
> #2
> This second option may be expensive if we have to order the beans everytime we execute the logic, and if this bean is applicationscoped, it wont make sense to do the ordering in the method call.
> {code:java}
> @Any
> @Inject
> private Instance<MyBeanInterface> myBeans;
> public void doSomething() {
>   Iterable<MyBeanInterface> orderedbeans = createOrder(myBeans.select(someQualifier));
> }
> {code}
> h3. Our Proposal
> We already have {{javax.annotation.Priority}} or any cdi specific annotation which we can add to {{MyBeanInterfaceImpl}} so that on injection of an {{Instance<MyBeanInterface>}}, all possible injection values are sorted based on the {{Priority.value()}} and if no annotation is defined, defaults to {{Priority.value = Integer.MAX_VALUE}}
> {code:java}
> public interface MyBeanInterface {}
> @MyQualifier
> @Priority(0)
> public class MyFirstBean implements MyBeanInterface{
> }
> @MyQualifier
> @Priority(2)
> public class MySecondBean implements MyBeanInterface{
> }
> @ApplicationScoped
> public class MyBeanProcessor {
>   //We expect that this injected instances shall be in order based on the @Priority annotation
>   @Any
>   @Inject
>   private Instance<MyBeanInterface> myBeans;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)