[cdi-dev] [JBoss JIRA] (CDI-746) PBA should be fired just after PAT and not after PIP or PIT

[Romain Manni-Bucau (Jira)]

    [ https://issues.redhat.com/browse/CDI-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145968#comment-14145968 ] 

Romain Manni-Bucau commented on CDI-746:
----------------------------------------

[~manovotn] ok so there are two things to consider:

 
 # PIP/PIT as collectors of meta to add beans
 # PIP/PIT as "evaluator for vetoing"

(1) is broken by such a rule, (2) is enabled by this rule.

However, I didn't see a single extension doing 2 but I saw several doing 1 without the safeness of validating it had been veto or not since it is way too much complex so I think this should be changed by the practise. Do you have some counter examples - hopefully public?

 

Side note: they are orphan in (1) and lead to a wrong extension impl whereas PIP should be usable to collect injections, or rephrased: if a PBA is veto there is no injection point for it so it shouldn't be fired ;).

> PBA should be fired just after PAT and not after PIP or PIT
> -----------------------------------------------------------
>
>                 Key: CDI-746
>                 URL: https://issues.redhat.com/browse/CDI-746
>             Project: CDI Specification Issues
>          Issue Type: Bug
>          Components: Portable Extensions
>    Affects Versions: 2.0.SP1
>            Reporter: Romain Manni-Bucau
>            Priority: Major
>
> Today spec put PBA after PIP and PIT which leads to have orphan events for PIP and PIT and thefore register wrong beans in portable extensions if PBA is veto.
> Luckily today PBA is not that used but we should ensure vetos happen before any other events to ease work for extension author (didn't see any extension checking the information captured are no more relevant today so this affects pretty much all extensions + it breaks extension and alternative support in most cases).
> Proposal is to move up the PBA event after PAT one enabling a straight forward extension API instead of a very complex one for meta capture today.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)