<div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 19, 2015 at 8:43 PM, Mark Struberg <span dir="ltr"><<a href="mailto:struberg@yahoo.de" target="_blank">struberg@yahoo.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Imagine you write some business code and your Observer needs a @RequestScoped LoggedInUser.<br>
The event gets fired by some cool library you use.<br>
<br>
Now this cool library updates to CDI-2.0 and uses fireAsync from now on. But your code still needs the @RequestScoped LoggedInUser on the same thread -> booooom.<br></blockquote><div><br></div><div>You are right that this would indeed break, and that's of course bad.</div><div><br></div><div>This particular situation might be prevented though by having an @RequestScoped producer for LoggedInUser, that fetches the application specific representation of the user based on the user/caller principal. If the request scope is not propagated to async observers, but the security context is, then the code would keep working and only behind the scenes will cause the producer method to be called again.</div><div><br></div><div>But that's just for this particular situation. Any dependency on other kinds of request scoped beans would still fail of course.</div><div><br></div><div>Kind regards,</div><div>Arjan Tijms</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
LieGrue,<br>
strub<br>
<br>
> Am 19.03.2015 um 18:17 schrieb José Paumard <<a href="mailto:jose.paumard@gmail.com">jose.paumard@gmail.com</a>>:<br>
<div class=""><div class="h5">><br>
> I see the situation as being :<br>
> - CDI 1.x : I call event.fireEvent(...), there is an observer that is called. Currently it is called in the same thread.<br>
> - CDI 2.0 : I call event.fireEvent(...), there is an observer that is called. It will be called in the same thread.<br>
><br>
> So what is the backward compatibility issue here ? From what I understand it just works the same.<br>
><br>
> José<br>
><br>
><br>
> 2015-03-19 17:19 GMT+01:00 Antoine Sabot-Durand <<a href="mailto:antoine@sabot-durand.net">antoine@sabot-durand.net</a>>:<br>
> The killer argument is that nobody succeed to provide a way to prevent opt-in and keep backward compaibility. The problem comes from the fact that producer and consumer can be in different jar compiled with different version of CDI and running on CDI 2.0 preventing using opt-out.<br>
> If you have the solution without opt-in I’m all ears.<br>
><br>
><br>
>> Le 19 mars 2015 à 16:52, José Paumard <<a href="mailto:jose.paumard@gmail.com">jose.paumard@gmail.com</a>> a écrit :<br>
>><br>
>> > So it seems impossible to avoid opt-in on the observer side<br>
>> What is the "killer" argument for that ?<br>
>><br>
>> José<br>
>><br>
>> 2015-03-19 16:44 GMT+01:00 Antoine Sabot-Durand <<a href="mailto:antoine@sabot-durand.net">antoine@sabot-durand.net</a>>:<br>
>><br>
>>> Le 19 mars 2015 à 15:51, Romain Manni-Bucau <<a href="mailto:rmannibucau@gmail.com">rmannibucau@gmail.com</a>> a écrit :<br>
>>><br>
>>> sounds like a quick and dirty solution to me. @Async will arrive<br>
>><br>
>> Yes like in “Async is coming” ;)<br>
>><br>
>>> - maybe too early today - but adding @ObservesAsync just cause we dont have yet @Async will make this API obselete pretty quickly isn't it (already cause of EJB actually).<br>
>><br>
>> and if we add an @Async in our spec you think it’s better ?<br>
>><br>
>>><br>
>>> Do we really want this feature at this price?<br>
>><br>
>> #1 requested feature by users.<br>
>><br>
>>> If yes AsyncObserves sounds an acceptable compromise but still will mess up the API IMO.<br>
>><br>
>> The question is “Is it more or less messy than @Async @Observes?" I don’t know… It has pros and cons as I listed...<br>
>><br>
>>><br>
>>><br>
>>> Romain Manni-Bucau<br>
>>> @rmannibucau | Blog | Github | LinkedIn | Tomitriber<br>
>>><br>
>>> 2015-03-19 15:36 GMT+01:00 Antoine Sabot-Durand <<a href="mailto:antoine@sabot-durand.net">antoine@sabot-durand.net</a>>:<br>
>>> Hi guys,<br>
>>><br>
>>><br>
>>> So it seems impossible to avoid opt-in on the observer side for the sake of awkward compatibility.<br>
>>> Adding a member to @Observes could also be a source of issues when old CDI lib will be used with CDI 2.0 runtime. Some of us (including me) don’t want to add an @Async annotation to CDI spec, so perhaps we should add an async alternative to @Observes with an @AsyncObserves or @ObservesAsync ?<br>
>>><br>
>>> So it would be<br>
>>><br>
>>> public void myObserver(@AsyncObserves payload) {}<br>
>>><br>
>>> instead of<br>
>>><br>
>>> @Async<br>
>>> public void myObserver(@Observes payload) {}<br>
>>><br>
>>><br>
>>> Pros :<br>
>>> - it’s a cleaner way to manage the opt-in than to put 2 annotations or add a member to an existing one<br>
>>> - it could have new members related to async behavior (context propagation, concurrent scenario, etc…)<br>
>>> - As it won’t be in legacy code no risk to see old observers called asynchronously<br>
>>><br>
>>> Cons :<br>
>>> - Still not clear for users when fire() is called to see @AsyncObserves launched synchronously<br>
>>> - Yet another annotation added<br>
>>><br>
>>> wdyt ?<br>
>>><br>
>>> Antoine<br>
>>><br>
>>> _______________________________________________<br>
>>> cdi-dev mailing list<br>
>>> <a href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
>>><br>
>>> Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br>
>>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> cdi-dev mailing list<br>
>> <a href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
>><br>
>> Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br>
>><br>
>><br>
>><br>
>> --<br>
>> Java le soir Cours Java en ligne<br>
>> Twitter Paris JUG Devoxx France<br>
>> M : <a href="tel:%2B33%206%2076%2082%2091%2047" value="+33676829147">+33 6 76 82 91 47</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Java le soir Cours Java en ligne<br>
> Twitter Paris JUG Devoxx France<br>
> M : <a href="tel:%2B33%206%2076%2082%2091%2047" value="+33676829147">+33 6 76 82 91 47</a><br>
> _______________________________________________<br>
> cdi-dev mailing list<br>
> <a href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
><br>
> Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br>
<br>
<br>
_______________________________________________<br>
cdi-dev mailing list<br>
<a href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
<br>
Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.</div></div></blockquote></div><br></div></div>