<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr">
<p>Makes sense if we want to add "as a bean" to the discovered text as a classifier for its usage.</p>
<p><br>
</p>
<p>John</p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Emily Jiang <EMIJIANG@uk.ibm.com><br>
<b>Sent:</b> Monday, November 21, 2016 12:05 PM<br>
<b>To:</b> Martin Kouba<br>
<b>Cc:</b> John Ament; Antoine Sabot-Durand; CDI Java EE Specification<br>
<b>Subject:</b> Re: [cdi-dev] Need native speaker for CDI-420 (trim) reword</font>
<div> </div>
</div>
<div><font size="2" face="sans-serif">+1 on Martin's suggestion!</font> <br>
<font size="2" face="sans-serif">How about the following rewording?</font> <br>
<tt><font size="2"> "If an explicit bean archive contains the `<trim/>` element in its `beans.xml` file, then for a
<b>type </b>to be <b>discovered </b>it must have either a<br>
scope annotation (normal or pseudo) or a bean defining annotation (as defined in <<bean_defining_annotations>>)"</font></tt>
<br>
<font size="2" face="sans-serif">=></font> <br>
<tt><font size="2"> "If an explicit bean archive contains the `<trim/>` element in its `beans.xml` file, then for a
<b>class </b>to be <b>discovered as a bean</b> it must have either a scope annotation (normal or pseudo) or a bean defining annotation (as defined in <<bean_defining_annotations>>)"</font></tt>
<br>
<br>
<font size="2" face="sans-serif">Many thanks,<br>
Emily<br>
===========================<br>
Emily Jiang<br>
WebSphere Application Server, CDI Development Lead</font> <br>
<font size="2" face="sans-serif"> <br>
MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN<br>
Phone: +44 (0)1962 816278 Internal: 246278<br>
<br>
Email: emijiang@uk.ibm.com <br>
Lotus Notes: Emily Jiang/UK/IBM@IBMGB<br>
</font><br>
<br>
<br>
<br>
<font size="1" color="#5f5f5f" face="sans-serif">From: </font><font size="1" face="sans-serif">Martin Kouba <mkouba@redhat.com></font>
<br>
<font size="1" color="#5f5f5f" face="sans-serif">To: </font><font size="1" face="sans-serif">John Ament <john.ament@spartasystems.com>, Antoine Sabot-Durand <antoine@sabot-durand.net>, CDI Java EE Specification <cdi-dev@lists.jboss.org></font>
<br>
<font size="1" color="#5f5f5f" face="sans-serif">Date: </font><font size="1" face="sans-serif">21/11/2016 14:34</font>
<br>
<font size="1" color="#5f5f5f" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [cdi-dev] Need native speaker for CDI-420 (trim) reword</font>
<br>
<font size="1" color="#5f5f5f" face="sans-serif">Sent by: </font><font size="1" face="sans-serif">cdi-dev-bounces@lists.jboss.org</font>
<br>
<hr noshade="">
<br>
<br>
<br>
<tt><font size="2">Well, we're discussing the spec wording which should be clear and
<br>
accurate. What users follow or not is a different thing, and should be <br>
covered in tutorials, blogposts and docs.<br>
<br>
To sum it up:<br>
<br>
* type discovery is covered in "12.4.1. Type discovery"<br>
* the "trimming" process happens AFTER type discovery and BEFORE bean <br>
discovery ("12.4.3. Bean discovery")<br>
<br>
Therefore, we cannot say that "for a type to be discovered it must <br>
have..." because for trimmed archives the type is always discovered and <br>
then, if it does not meet the conditions, thrown away (no beans are <br>
created from it).<br>
<br>
Martin<br>
<br>
Dne 21.11.2016 v 14:53 John Ament napsal(a):<br>
> What you're referring to is a nuance that most users don't follow. A<br>
> PAT is fired for essentially every class found. If this works<br>
> differently (e.g. for bean-discovery-mode=none) then it may be worth<br>
> calling this out, but as of now it should be implicit that PAT works<br>
> differently.<br>
><br>
><br>
> John<br>
><br>
><br>
><br>
> ------------------------------------------------------------------------<br>
> *From:* Antoine Sabot-Durand <antoine@sabot-durand.net><br>
> *Sent:* Monday, November 21, 2016 5:07 AM<br>
> *To:* Martin Kouba; John Ament; CDI Java EE Specification<br>
> *Subject:* Re: [cdi-dev] Need native speaker for CDI-420 (trim) reword<br>
><br>
> +1 for Martin. I didn't read with enough attention. All Types should be<br>
> discovered like in All bean-discovery mode , but only those with bean<br>
> defining annotation or scope should be eligible to become beans.<br>
><br>
> On Mon, Nov 21, 2016 at 9:15 AM Martin Kouba <mkouba@redhat.com<br>
> <</font></tt><a href="mailto:mkouba@redhat.com"><tt><font size="2">mailto:mkouba@redhat.com</font></tt></a><tt><font size="2">>> wrote:<br>
><br>
> Hi John,<br>
><br>
> sounds good but is not entirely correct because those type ARE actually<br>
> discovered (ProcessAnnotatedType is fired etc.) and then removed (if<br>
> necessary) from the set of discovered types before the "Bean discovery"<br>
> phase.<br>
><br>
> Martin<br>
><br>
> Dne 18.11.2016 v 16:50 John Ament napsal(a):<br>
> > Here's my take..<br>
> ><br>
> ><br>
> > "If an explicit bean archive contains the `<trim/>` element in its<br>
> > `beans.xml` file, then for a type to be discovered it must have<br>
> either a<br>
> > scope annotation (normal or pseudo) or a bean defining annotation (as<br>
> > defined in <<bean_defining_annotations>>)"<br>
> ><br>
> ><br>
> > John<br>
> ><br>
> ><br>
> ><br>
> ><br>
> ------------------------------------------------------------------------<br>
> > *From:* cdi-dev-bounces@lists.jboss.org<br>
> <</font></tt><a href="mailto:cdi-dev-bounces@lists.jboss.org"><tt><font size="2">mailto:cdi-dev-bounces@lists.jboss.org</font></tt></a><tt><font size="2">><br>
> > <cdi-dev-bounces@lists.jboss.org<br>
> <</font></tt><a href="mailto:cdi-dev-bounces@lists.jboss.org"><tt><font size="2">mailto:cdi-dev-bounces@lists.jboss.org</font></tt></a><tt><font size="2">>> on behalf of Antoine<br>
> Sabot-Durand<br>
> > <antoine@sabot-durand.net <</font></tt><a href="mailto:antoine@sabot-durand.net"><tt><font size="2">mailto:antoine@sabot-durand.net</font></tt></a><tt><font size="2">>><br>
> > *Sent:* Friday, November 18, 2016 9:30 AM<br>
> > *To:* CDI Java EE Specification<br>
> > *Subject:* [cdi-dev] Need native speaker for CDI-420 (trim) reword<br>
> ><br>
> > Hi all,<br>
> ><br>
> ><br>
> > With Martin, we reword the <trim/> section like:<br>
> ><br>
> > "If an explicit bean archive contains the `<trim/>` element in its<br>
> > `beans.xml` file, types that don't have either a bean defining<br>
> > annotation (as defined in <<bean_defining_annotations>>) or any scope<br>
> > annotation, are removed from the set of discovered types."<br>
> ><br>
> > Grammar feedback from native speaker is most welcome.<br>
> ><br>
> > Antoine<br>
> ><br>
> ------------------------------------------------------------------------<br>
> > NOTICE: This e-mail message and any attachments may contain<br>
> > confidential, proprietary, and/or privileged information which<br>
> should be<br>
> > treated accordingly. If you are not the intended recipient, please<br>
> > notify the sender immediately by return e-mail, delete this<br>
> message, and<br>
> > destroy all physical and electronic copies. Thank you.<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > cdi-dev mailing list<br>
> > cdi-dev@lists.jboss.org <</font></tt><a href="mailto:cdi-dev@lists.jboss.org"><tt><font size="2">mailto:cdi-dev@lists.jboss.org</font></tt></a><tt><font size="2">><br>
> > </font></tt><a href="https://lists.jboss.org/mailman/listinfo/cdi-dev"><tt><font size="2">https://lists.jboss.org/mailman/listinfo/cdi-dev</font></tt></a><tt><font size="2"><br>
> ><br>
> > Note that for all code provided on this list, the provider<br>
> licenses the code under the Apache License, Version 2<br>
> (</font></tt><a href="http://www.apache.org/licenses/LICENSE-2.0.html"><tt><font size="2">http://www.apache.org/licenses/LICENSE-2.0.html</font></tt></a><tt><font size="2">). For all other<br>
> ideas provided on this list, the provider waives all patent and<br>
> other intellectual property rights inherent in such information.<br>
> ><br>
><br>
> --<br>
> Martin Kouba<br>
> Software Engineer<br>
> Red Hat, Czech Republic<br>
><br>
> ------------------------------------------------------------------------<br>
> NOTICE: This e-mail message and any attachments may contain<br>
> confidential, proprietary, and/or privileged information which should be<br>
> treated accordingly. If you are not the intended recipient, please<br>
> notify the sender immediately by return e-mail, delete this message, and<br>
> destroy all physical and electronic copies. Thank you.<br>
<br>
-- <br>
Martin Kouba<br>
Software Engineer<br>
Red Hat, Czech Republic<br>
_______________________________________________<br>
cdi-dev mailing list<br>
cdi-dev@lists.jboss.org<br>
</font></tt><a href="https://lists.jboss.org/mailman/listinfo/cdi-dev"><tt><font size="2">https://lists.jboss.org/mailman/listinfo/cdi-dev</font></tt></a><tt><font size="2"><br>
<br>
Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (</font></tt><a href="http://www.apache.org/licenses/LICENSE-2.0.html"><tt><font size="2">http://www.apache.org/licenses/LICENSE-2.0.html</font></tt></a><tt><font size="2">).
For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br>
<br>
</font></tt><br>
<font size="2" face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number 741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU<br>
</font></div>
</div>
</div>
<hr>
NOTICE: This e-mail message and any attachments may contain confidential, proprietary, and/or privileged information which should be treated accordingly. If you are not the intended recipient, please notify the sender immediately by return e-mail, delete this
message, and destroy all physical and electronic copies. Thank you.
</body>
</html>