[dna-commits] DNA SVN: r510 - in trunk/dna-jcr/src: test/java/org/jboss/dna/jcr and 1 other directory.

[dna-commits at lists.jboss.org]

Author: jverhaeg at redhat.com
Date: 2008-09-09 11:58:30 -0400 (Tue, 09 Sep 2008)
New Revision: 510

Modified:
   trunk/dna-jcr/src/main/java/org/jboss/dna/jcr/JcrSession.java
   trunk/dna-jcr/src/test/java/org/jboss/dna/jcr/JcrSessionTest.java
Log:
DNA-178: Lost some code when I updated before my last commit.

Modified: trunk/dna-jcr/src/main/java/org/jboss/dna/jcr/JcrSession.java
===================================================================
--- trunk/dna-jcr/src/main/java/org/jboss/dna/jcr/JcrSession.java	2008-09-09 15:18:27 UTC (rev 509)
+++ trunk/dna-jcr/src/main/java/org/jboss/dna/jcr/JcrSession.java	2008-09-09 15:58:30 UTC (rev 510)
@@ -470,7 +470,11 @@
      * @see javax.jcr.Session#itemExists(java.lang.String)
      */
     public boolean itemExists( String absolutePath ) throws RepositoryException {
-        return (getItem(absolutePath) != null);
+        try {
+            return (getItem(absolutePath) != null);
+        } catch (PathNotFoundException error) {
+            return false;
+        }
     }
 
     /**

Modified: trunk/dna-jcr/src/test/java/org/jboss/dna/jcr/JcrSessionTest.java
===================================================================
--- trunk/dna-jcr/src/test/java/org/jboss/dna/jcr/JcrSessionTest.java	2008-09-09 15:18:27 UTC (rev 509)
+++ trunk/dna-jcr/src/test/java/org/jboss/dna/jcr/JcrSessionTest.java	2008-09-09 15:58:30 UTC (rev 510)
@@ -274,6 +274,17 @@
 
     @Test
     public void shouldProvideItemExists() throws Exception {
-        assertThat(session.itemExists(""), is(false));
+        assertThat(session.itemExists("/a/b"), is(true));
+        assertThat(session.itemExists("/a/c"), is(false));
     }
+
+    @Test( expected = IllegalArgumentException.class )
+    public void shouldNotAllowItemExistsWithNoPath() throws Exception {
+        session.itemExists(null);
+    }
+
+    @Test( expected = IllegalArgumentException.class )
+    public void shouldNotAllowItemExistsWithEmptyPath() throws Exception {
+        session.itemExists("");
+    }
 }