[dna-dev] NetChangeObserver Questions

[Daniel Florian]

Here are some questions concerning the NetChangeObserver class which I am modifying whilst implenting the observation feature:

1. How do the CopyBranchRequest, CloneBranchRequest, RenameNodeRequest, and MoveBranchRequest create the node properties (and children)? I was expecting these types to be Iterable<Property> just like CreateNodeRequest so that I could generate the new property events. Don't I also need to add these property added events?

2. The docs for UpdateValuesRequest states that it can be used for a new property. If true, it would need the "isNewProperty()" method that was recently added to SetPropertyRequest and UpdatePropertiesRequest. Are the docs right?

3. There is no way to get the Property object from UpdateValuesRequest. The Property type is needed in the call to NetChangeDetails.changedProperty(Property) and NetChangeDetails.addProperty(Property).

4. I added code to handle CreateWorkspaceRequest, DestroyWorkspaceRequest, and CloneWorkspaceRequest. Right now it just creates a NODE_ADDED event for the root node. Seems like I could remove all the code for these requests as no listeners could possibly exist for these new/deleted workspaces. Agree? If not, the CreateWorkspaceRequest and CloneWorkspaceRequest will need a way to say what properties were added to the root node. Same issue as #1 above.