[dna-issues] [JBoss JIRA] Commented: (DNA-250) Creating a path from a parent path and a segment is not fast

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12441847#action_12441847 ] 

Randall Hauch commented on DNA-250:
-----------------------------------

Added an optimized check during the isAtOrBelow and isAtOrAbove methods, and removed the caching of the string form of the path (which was cached based upon the first call to any of the getString methods, regardless of the NamespaceRegistry instance used, meaning the cached string might have used no namespace registry and was returned from a getString(...) that took a namespace registry.  Also, the extra overhead of the cached string was not worth the memory.

> Creating a path from a parent path and a segment is not fast
> ------------------------------------------------------------
>
>                 Key: DNA-250
>                 URL: https://jira.jboss.org/jira/browse/DNA-250
>             Project: DNA
>          Issue Type: Bug
>          Components: Graph
>    Affects Versions: 0.3
>            Reporter: Randall Hauch
>            Assignee: Randall Hauch
>            Priority: Critical
>             Fix For: 0.4
>
>
> Currently, we only have one implementation of Path, and each instance contains a list of the Path.Segment instances in the path.  Although the actual Path.Segment instances are shared when creating a path using a parent path, the actual list is not shared.  And this means new allocation for each Path.  This could be more efficient, especially since creating a path from a parent path and a name is perhaps one of the most frequently used methods.
> We probably need an implementation of Path that contains a name plus a reference to a parent.  This would have a smaller memory footprint as well as be faster to create.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira