[dna-issues] [JBoss JIRA] Commented: (DNA-242) Change the XML importer code to no longer use XmlSequencer

Mon Oct 27 23:01:20 EDT 2008

    [ https://jira.jboss.org/jira/browse/DNA-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12435660#action_12435660 ] 

Randall Hauch commented on DNA-242:
-----------------------------------

Added new XmlHandler implementation (which subclasses DefaultHandler2 and overrides the appropriate methods) with a unit test that verifies the behavior.  It is designed to be used with a regular org.xml.sax.XMLReader implementation, but processes the XML content and creates the nodes that represent that content.  And while the current component should be perfect for importing XML content into a repository, it can also be subclassed with other DefaultHandler2 methods being overridden to handle other parts of the XML content, including XML comments, DTD entities, entity resolution, etc.  This approach of specializing a DefaultHandler2 implementation is much more extensible and customizable than providing an "importer" component.

Still have to make the change to use this new component.

> Change the XML importer code to no longer use XmlSequencer
> ----------------------------------------------------------
>
>                 Key: DNA-242
>                 URL: https://jira.jboss.org/jira/browse/DNA-242
>             Project: DNA
>          Issue Type: Task
>          Components: Graph
>    Affects Versions: 0.2
>            Reporter: Randall Hauch
>            Assignee: Randall Hauch
>            Priority: Critical
>             Fix For: 0.3
>
>
> The XML import capability is currently reusing the XmlSequencer for it's implementation.  The XmlSequencer behavior, however, doesn't really generate the graph content that is compatible with "importing JCR graph content".  For example, it includes in the generated content all of the DTD entities, comments, etc.
> So, we should really move most of this functionality into an XML importer class that is relatively configurable in what it's behavior is.  (For example, retain DTD content, retain XML comments, replace entity references with values, etc.)  Then, this should be used for the Graph importer, and it can be used by the XmlSequencer.
> Because the XmlSequencer doesn't really work for how it's used, JPAV and I agree that it is critical to fix in 0.3.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira