[dna-issues] [JBoss JIRA] Resolved: (DNA-224) dna-connector-federation: one test in FederatingCommandExecutorTest doesn't work with JDK 1.6.0_05 on Mac OS X

[Randall Hauch (JIRA)]

     [ https://jira.jboss.org/jira/browse/DNA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randall Hauch resolved DNA-224.
-------------------------------

    Resolution: Done


The problem appeared because of a modified implementation of a Set, which resulted in a different order to some of the top-level nodes in a Projection.  This in fact was a bug where the top-level nodes of a projection were not ordered.  This was fixed by making them ordered, keeping the same order as the projection's rules.

All tests now pass on JDK 1.5 and JDK 1.6.

Also corrected several compiler warnings when compiling under JDK 1.6, some of which involved using TimeUnit.convert(...) to do conversions rather than switch statements.  (Not only is it more correct, but JDK 1.6 adds more enumerations to the TimeUnit enum, which broke the previous logic.)

> dna-connector-federation: one test in FederatingCommandExecutorTest doesn't work with JDK 1.6.0_05 on Mac OS X
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: DNA-224
>                 URL: https://jira.jboss.org/jira/browse/DNA-224
>             Project: DNA
>          Issue Type: Bug
>          Components: Connectors
>    Affects Versions: 0.2
>         Environment: testing 
>            Reporter: Serge Emmanuel Pagop
>            Assignee: Randall Hauch
>             Fix For: 0.2
>
>
> first I change my jdk 1.5 to the jdk version "1.6.0_05" and I tried to run "mvn clean install" and the test process is broken in the dna-connector-federation module with an error (see below), but with the jdk 1.5 there is no problem.
> -------------------------------------------------------------------------------
> Test set: org.jboss.dna.connector.federation.executor.FederatingCommandExecutorTest
> -------------------------------------------------------------------------------
> Tests run: 21, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.105 sec <<< FAILURE!
> shouldLoadContributionsForRootNodeFromSources(org.jboss.dna.connector.federation.executor.FederatingCommandExecutorTest)  Time elapsed: 0.005 sec  <<< FAILURE!
> java.lang.AssertionError: 
> Expected: (a iterator containing <{}a> and a iterator containing <{}b>)
>      got: <org.jboss.dna.connector.federation.contribution.Contribution$TwoValueIterator at 1d83004b>
> 	at org.junit.Assert.assertThat(Assert.java:502)
> 	at org.junit.Assert.assertThat(Assert.java:492)
> 	at org.jboss.dna.connector.federation.executor.FederatingCommandExecutorTest.shouldLoadContributionsForRootNodeFromSources(FederatingCommandExecutorTest.java:265)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
> 	at org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
> 	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
> 	at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
> 	at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
> 	at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
> 	at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
> 	at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
> 	at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
> 	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
> 	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
> 	at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
> 	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
> 	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
> 	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
> 	at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:338)
> 	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:997)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira