[dna-issues] [JBoss JIRA] Commented: (DNA-357) Hide dna:nodeDefinition Property from Users

Wed Apr 15 21:51:22 EDT 2009

    [ https://jira.jboss.org/jira/browse/DNA-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12462495#action_12462495 ] 

Randall Hauch commented on DNA-357:
-----------------------------------

I'm fine with hiding it, though we need to do a little better about not letting users modify it.  In essence, it needs to be protected property (in the editing sense).  

The JCR spec doesn't really say it's invalid to add additional properties to "nt:base", but it does say (section 6.7.22.2) that "An implementation may extend the definition of any predefined node type by adding supertypes to those defined in this specification."  Since we cannot add mixins to "nt:base", I would think we could add "dna:nodeDefinition" to nt:base as a protected, non-mandatory (optional), and autoCreated property.  So even though we continue to hide it the property, having the property definition prevents users from setting it on a node (whether or not one is already there).

Thoughts?

> Hide dna:nodeDefinition Property from Users
> -------------------------------------------
>
>                 Key: DNA-357
>                 URL: https://jira.jboss.org/jira/browse/DNA-357
>             Project: DNA
>          Issue Type: Feature Request
>          Components: JCR
>            Reporter: Brian Carothers
>            Priority: Minor
>         Attachments: DNA-357.patch
>
>
> dna:nodeDefinition is a bit of an odd duck.  It is set on every property but doesn't always have a valid JCR definition.  This breaks an export-import round trip as the property cannot be set during import.  It also breaks a few TCK tests that assume a jcr:xmltext node only has two properties (jcr:primaryType and jcr:xmlcharacters), but that's really a TCK defect.
> Can we just suppress this property at the JCR layer?  It would still be available for internal use but would not appear to end users.  Alternatively, we should modify our definition for nt:base to include it as a protected property - this solution may violate the spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira